2007-10-23 01:16:51

by Roel Kluin

Subject: [PATCH] Unlock before return in p9_mux_poll_start

commit 9f822afc65cc094c905901f9d92bf25042f9ed22
Author: Roel Kluin <[email protected]>
Date: Tue Oct 23 03:15:55 2007 +0200

Unlock before return in p9_mux_poll_start

Signed-off-by: Roel Kluin <[email protected]>

diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140147..c9f0805 100644
--- a/net/9p/mux.c
+++ b/net/9p/mux.c
@@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m)
}

if (i >= ARRAY_SIZE(p9_mux_poll_tasks)) {
- if (vptlast == NULL)
+ if (vptlast == NULL) {
+ mutex_unlock(&p9_mux_task_lock);
return -ENOMEM;
+ }

P9_DPRINTK(P9_DEBUG_MUX, "put in proc %d\n", i);
list_add(&m->mux_list, &vptlast->mux_list);

2007-10-24 03:53:19

by David Miller

Subject: Re: [PATCH] Unlock before return in p9_mux_poll_start

From: Roel Kluin <[email protected]>
Date: Tue, 23 Oct 2007 03:16:41 +0200

> commit 9f822afc65cc094c905901f9d92bf25042f9ed22
> Author: Roel Kluin <[email protected]>
> Date: Tue Oct 23 03:15:55 2007 +0200
>
> Unlock before return in p9_mux_poll_start
>
> Signed-off-by: Roel Kluin <[email protected]>

Applied, thanks!