2007-10-23 22:39:58

by Jeff Garzik

Subject: [PATCH 10/12] mac80211: fix warning created by BIT()

Now that BIT() forces unsigned long, this warning appears:

net/mac80211/ieee80211_sta.c: In function ‘ieee80211_rx_mgmt_assoc_resp’:
net/mac80211/ieee80211_sta.c:1187: warning: format ‘%d’ expects type ‘int’, but argument 7 has type ‘long unsigned int’

Signed-off-by: Jeff Garzik <[email protected]>
---

diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c
index f7ffeec..bdfd901 100644
--- a/net/mac80211/ieee80211_sta.c
+++ b/net/mac80211/ieee80211_sta.c
@@ -1182,7 +1182,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
aid = le16_to_cpu(mgmt->u.assoc_resp.aid);

printk(KERN_DEBUG "%s: RX %sssocResp from %s (capab=0x%x "
- "status=%d aid=%d)\n",
+ "status=%d aid=%ld)\n",
dev->name, reassoc ? "Rea" : "A", print_mac(mac, mgmt->sa),
capab_info, status_code, aid & ~(BIT(15) | BIT(14)));

2007-10-23 23:15:51

by Randy Dunlap

Subject: Re: [PATCH 10/12] mac80211: fix warning created by BIT()

On Tue, 23 Oct 2007 18:36:45 -0400 (EDT) Jeff Garzik wrote:

> Now that BIT() forces unsigned long, this warning appears:
>
> net/mac80211/ieee80211_sta.c: In function ‘ieee80211_rx_mgmt_assoc_resp’:
> net/mac80211/ieee80211_sta.c:1187: warning: format ‘%d’ expects type ‘int’, but argument 7 has type ‘long unsigned int’

LC_ALL=C make ...


> Signed-off-by: Jeff Garzik <[email protected]>
> ---
>
> diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c
> index f7ffeec..bdfd901 100644
> --- a/net/mac80211/ieee80211_sta.c
> +++ b/net/mac80211/ieee80211_sta.c
> @@ -1182,7 +1182,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
> aid = le16_to_cpu(mgmt->u.assoc_resp.aid);
>
> printk(KERN_DEBUG "%s: RX %sssocResp from %s (capab=0x%x "
> - "status=%d aid=%d)\n",
> + "status=%d aid=%ld)\n",
> dev->name, reassoc ? "Rea" : "A", print_mac(mac, mgmt->sa),
> capab_info, status_code, aid & ~(BIT(15) | BIT(14)));
>
> -

Patch was submitted yesterday by Johannes Berg, but does need to be
pushed by someone... (like this)


---
~Randy