2007-10-24 17:09:23

by Matthias Kaehlcke

[permalink] [raw]
Subject: [patch 0/3] MBCS: Convert semaphores to the mutex API

MBCS: Convert the semaphores algolock, dmareadlock and dmawritelock to the
mutex API

--
Matthias Kaehlcke
Linux Application Developer
Barcelona

We build too many walls and not enough bridges
(Isaac Newton)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-


2007-10-25 04:12:13

by Andrew Morton

[permalink] [raw]
Subject: Re: [patch 0/3] MBCS: Convert semaphores to the mutex API

On Wed, 24 Oct 2007 19:08:58 +0200 [email protected] wrote:

> MBCS: Convert the semaphores algolock, dmareadlock and dmawritelock to the
> mutex API

Thanks. Has this actually been runtime-tested?

btw, your patches are in `patch -p2' form:

--- kernel.orig/linux-2.6/drivers/char/mbcs.c
+++ kernel/linux-2.6/drivers/char/mbcs.c

should have been in `patch -p1' form:

--- linux-2.6/drivers/char/mbcs.c
+++ linux-2.6/drivers/char/mbcs.c

I'd suggest that you grab and learn
http://savannah.nongnu.org/projects/quilt/ - it takes care of all these
things for you.

2007-10-25 05:47:32

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: [patch 0/3] MBCS: Convert semaphores to the mutex API

El Wed, Oct 24, 2007 at 09:11:49PM -0700 Andrew Morton ha dit:

> On Wed, 24 Oct 2007 19:08:58 +0200 [email protected] wrote:
>
> > MBCS: Convert the semaphores algolock, dmareadlock and dmawritelock to the
> > mutex API
>
> Thanks. Has this actually been runtime-tested?

no, i could only test successfull compilation as i don't have the
device

> btw, your patches are in `patch -p2' form:
>
> --- kernel.orig/linux-2.6/drivers/char/mbcs.c
> +++ kernel/linux-2.6/drivers/char/mbcs.c
>
> should have been in `patch -p1' form:
>
> --- linux-2.6/drivers/char/mbcs.c
> +++ linux-2.6/drivers/char/mbcs.c
>
> I'd suggest that you grab and learn
> http://savannah.nongnu.org/projects/quilt/ - it takes care of all these
> things for you.

i actually used quilt for this patchset but must have missed
something. thanks for the pointer!

--
Matthias Kaehlcke
Linux Application Developer
Barcelona

Dreams and reality are opposites. Action synthesizes them
(Assata Shakur)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-