2007-10-28 03:29:40

by Cong Wang

Subject: UML building failed in current Linus-tree

Hi, Jeff, Sam!

I just pulled from Linus-tree, and got the following error when building uml.

$ make defconfig ARCH=um
/home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32: /home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu: No such file or directory
make: *** No rule to make target `/home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu'. Stop.

Is this a known problem? Yesterday's Linus-tree was fine.

Regards.

--
May the Source Be With You.

2007-10-28 03:43:54

by Al Viro

Subject: Re: UML building failed in current Linus-tree

On Sun, Oct 28, 2007 at 11:24:41AM +0800, WANG Cong wrote:
>
> Hi, Jeff, Sam!
>
> I just pulled from Linus-tree, and got the following error when building uml.
>
> $ make defconfig ARCH=um
> /home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32: /home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu: No such file or directory
> make: *** No rule to make target `/home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu'. Stop.
>
> Is this a known problem? Yesterday's Linus-tree was fine.

diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386
index 9876d80..e0ac74e 100644
--- a/arch/um/Kconfig.i386
+++ b/arch/um/Kconfig.i386
@@ -1,6 +1,6 @@
menu "Host processor type and features"

-source "arch/i386/Kconfig.cpu"
+source "arch/x86/Kconfig.cpu"

endmenu

diff --git a/arch/um/Makefile-i386 b/arch/um/Makefile-i386
index 08433f8..b01dfb0 100644
--- a/arch/um/Makefile-i386
+++ b/arch/um/Makefile-i386
@@ -28,7 +28,7 @@ CONFIG_X86_32 := y
export CONFIG_X86_32

# First of all, tune CFLAGS for the specific CPU. This actually sets cflags-y.
-include $(srctree)/arch/i386/Makefile.cpu
+include $(srctree)/arch/x86/Makefile_32.cpu

# prevent gcc from keeping the stack 16 byte aligned. Taken from i386.
cflags-y += $(call cc-option,-mpreferred-stack-boundary=2)

2007-10-28 05:30:42

by Cong Wang

Subject: Re: UML building failed in current Linus-tree

On Sun, Oct 28, 2007 at 03:43:43AM +0000, Al Viro wrote:
>On Sun, Oct 28, 2007 at 11:24:41AM +0800, WANG Cong wrote:
>>
>> Hi, Jeff, Sam!
>>
>> I just pulled from Linus-tree, and got the following error when building uml.
>>
>> $ make defconfig ARCH=um
>> /home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32: /home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu: No such file or directory
>> make: *** No rule to make target `/home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu'. Stop.
>>
>> Is this a known problem? Yesterday's Linus-tree was fine.
>
>diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386
>index 9876d80..e0ac74e 100644
>--- a/arch/um/Kconfig.i386
>+++ b/arch/um/Kconfig.i386

Thanks, Al.

With your patch, it works fine.

Jeff, could you please consider pushing this and Al's another patch[1] into
Linus-tree? UML in Linus-tree can't work for a long time. ;(

[1] http://lkml.org/lkml/2007/10/21/118

Regards.

WANG Cong