make headers_check currently fails in mainline with..
include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers
There's no reason to even include this in this header as far as I can tell.
Signed-off-by: Dave Jones <[email protected]>
diff --git a/include/linux/tipc_config.h b/include/linux/tipc_config.h
index b0c916d..83532ee 100644
--- a/include/linux/tipc_config.h
+++ b/include/linux/tipc_config.h
@@ -38,7 +38,6 @@
#define _LINUX_TIPC_CONFIG_H_
#include <linux/types.h>
-#include <linux/string.h>
#include <asm/byteorder.h>
/*
--
http://www.codemonkey.org.uk
On Wed, Oct 31, 2007 at 05:29:32PM -0400, Dave Jones wrote:
> make headers_check currently fails in mainline with..
>
> include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers
>
> There's no reason to even include this in this header as far as I can tell.
The inline functions uses memcpy().
But if you just pull a fresh tree you will notice that it is fixed.
Davem did so in a rather elegant way.
Sam
From: Dave Jones <[email protected]>
Date: Wed, 31 Oct 2007 17:29:32 -0400
> make headers_check currently fails in mainline with..
>
> include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers
>
> There's no reason to even include this in this header as far as I can tell.
>
> Signed-off-by: Dave Jones <[email protected]>
It uses memcpy() in the inline routines which are in fact used by both
userspace and the kernel. The change you are suggesting will also
break the TIPC kernel build.
A proper fix has been merged into Linus's tree already.