2007-11-05 02:32:42

by Li Zefan

Subject: [PATCH 6/6] W1: fix memset size error

The size arguments passing to memset is wrong.

Signed-off-by Li Zefan <[email protected]>

---
drivers/w1/masters/ds2490.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index 299e274..b63b5e0 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -233,7 +233,7 @@ static int ds_recv_status_nodump(struct ds_device *dev, struct ds_status *st,
{
int count, err;

- memset(st, 0, sizeof(st));
+ memset(st, 0, sizeof(*st));

count = 0;
err = usb_bulk_msg(dev->udev, usb_rcvbulkpipe(dev->udev, dev->ep[EP_STATUS]), buf, size, &count, 100);
--
1.5.3.rc7

2007-11-05 15:59:21

by Evgeniy Polyakov

Subject: Re: [PATCH 6/6] W1: fix memset size error

On Mon, Nov 05, 2007 at 10:30:44AM +0800, Li Zefan ([email protected]) wrote:
> The size arguments passing to memset is wrong.
>
> Signed-off-by Li Zefan <[email protected]>

Thanks a lot, patch is obviously correct.

ACK.

--
Evgeniy Polyakov