2007-11-10 11:13:09

by Diego Calleja

Subject: [PATCH] Improve cgroup printks

When I boot with the 'quiet' parameter, I see on the screen:

[ 0.000000] Initializing cgroup subsys cpuset
[ 0.000000] Initializing cgroup subsys cpu
[ 39.036026] Initializing cgroup subsys cpuacct
[ 39.036080] Initializing cgroup subsys debug
[ 39.036118] Initializing cgroup subsys ns

This patch lowers the priority of those messages, adds a "cgroup: " prefix
to another couple of printks and kills the useless reference to the source file.


Signed-off-by: Diego Calleja <[email protected]>

--- 2.6/kernel/cgroup.c.old 2007-11-10 11:35:51.000000000 +0100
+++ 2.6/kernel/cgroup.c 2007-11-10 11:56:46.000000000 +0100
@@ -1,6 +1,4 @@
/*
- * kernel/cgroup.c
- *
* Generic process-grouping system.
*
* Based originally on the cpuset system, extracted by Paul Menage
@@ -2200,7 +2198,7 @@ static void cgroup_init_subsys(struct cg
{
struct cgroup_subsys_state *css;
struct list_head *l;
- printk(KERN_ERR "Initializing cgroup subsys %s\n", ss->name);
+ printk("Initializing cgroup subsys %s\n", ss->name);

/* Create the top cgroup state for this subsystem */
ss->root = &rootnode;
@@ -2273,7 +2271,7 @@ int __init cgroup_init_early(void)
BUG_ON(!ss->create);
BUG_ON(!ss->destroy);
if (ss->subsys_id != i) {
- printk(KERN_ERR "Subsys %s id == %d\n",
+ printk(KERN_ERR "cgroup: Subsys %s id == %d\n",
ss->name, ss->subsys_id);
BUG();
}
@@ -2605,7 +2603,7 @@ int cgroup_clone(struct task_struct *tsk
dentry = lookup_one_len(nodename, parent->dentry, strlen(nodename));
if (IS_ERR(dentry)) {
printk(KERN_INFO
- "Couldn't allocate dentry for %s: %ld\n", nodename,
+ "cgroup: Couldn't allocate dentry for %s: %ld\n", nodename,
PTR_ERR(dentry));
ret = PTR_ERR(dentry);
goto out_release;

2007-11-11 22:48:46

by Jan Engelhardt

Subject: Re: [PATCH] Improve cgroup printks

>When I boot with the 'quiet' parameter, I see on the screen:
>
>[ 0.000000] Initializing cgroup subsys cpuset
>[ 0.000000] Initializing cgroup subsys cpu
>[ 39.036026] Initializing cgroup subsys cpuacct
>[ 39.036080] Initializing cgroup subsys debug
>[ 39.036118] Initializing cgroup subsys ns
>
>This patch lowers the priority of those messages, adds a "cgroup: "
>prefix to another couple of printks and kills the useless reference to
>the source file.

>- printk(KERN_ERR "Initializing cgroup subsys %s\n", ss->name);
>+ printk("Initializing cgroup subsys %s\n", ss->name);

Every printk should have a loglevel.

2007-11-12 22:13:08

by Andrew Morton

Subject: Re: [PATCH] Improve cgroup printks

On Sat, 10 Nov 2007 12:11:56 +0100 Diego Calleja <[email protected]> wrote:

> When I boot with the 'quiet' parameter, I see on the screen:
>
> [ 0.000000] Initializing cgroup subsys cpuset
> [ 0.000000] Initializing cgroup subsys cpu
> [ 39.036026] Initializing cgroup subsys cpuacct
> [ 39.036080] Initializing cgroup subsys debug
> [ 39.036118] Initializing cgroup subsys ns
>
> This patch lowers the priority of those messages, adds a "cgroup: " prefix
> to another couple of printks and kills the useless reference to the source file.
>
>
> Signed-off-by: Diego Calleja <[email protected]>
>
> --- 2.6/kernel/cgroup.c.old 2007-11-10 11:35:51.000000000 +0100
> +++ 2.6/kernel/cgroup.c 2007-11-10 11:56:46.000000000 +0100
> @@ -1,6 +1,4 @@
> /*
> - * kernel/cgroup.c
> - *
> * Generic process-grouping system.
> *
> * Based originally on the cpuset system, extracted by Paul Menage
> @@ -2200,7 +2198,7 @@ static void cgroup_init_subsys(struct cg
> {
> struct cgroup_subsys_state *css;
> struct list_head *l;
> - printk(KERN_ERR "Initializing cgroup subsys %s\n", ss->name);
> + printk("Initializing cgroup subsys %s\n", ss->name);

But this one now has no facility level at all.

I'll switch it to KERN_INFO, OK?

2007-11-12 23:47:19

by Paul Menage

Subject: Re: [PATCH] Improve cgroup printks

On Nov 10, 2007 3:11 AM, Diego Calleja <[email protected]> wrote:
> When I boot with the 'quiet' parameter, I see on the screen:
>
> [ 0.000000] Initializing cgroup subsys cpuset
> [ 0.000000] Initializing cgroup subsys cpu
> [ 39.036026] Initializing cgroup subsys cpuacct
> [ 39.036080] Initializing cgroup subsys debug
> [ 39.036118] Initializing cgroup subsys ns
>
> This patch lowers the priority of those messages, adds a "cgroup: " prefix
> to another couple of printks and kills the useless reference to the source file.
>
>
> Signed-off-by: Diego Calleja <[email protected]>

(with the addition of akpm's KERN_INFO for cgroup_init_subsys() )
Acked-by: Paul Menage <[email protected]>

Paul