2007-11-12 00:01:22

by Jesper Juhl

[permalink] [raw]
Subject: [PATCH] Let 'make help' output info about includecheck

From: Jesper Juhl <[email protected]>

'make includecheck' is useful and we want people to run it, so
let 'make help' output information about its existence.


Signed-off-by: Jesper Juhl <[email protected]>
---

Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index e28dde8..2e5eba0 100644
--- a/Makefile
+++ b/Makefile
@@ -1181,6 +1181,7 @@ help:
@echo ''
@echo 'Static analysers'
@echo ' checkstack - Generate a list of stack hogs'
+ @echo ' includecheck - Generate a list of files with duplicate header includes'
@echo ' namespacecheck - Name space analysis on compiled kernel'
@echo ' export_report - List the usages of all exported symbols'
@if [ -r $(srctree)/include/asm-$(SRCARCH)/Kbuild ]; then \



2007-11-14 03:03:44

by Cong Wang

[permalink] [raw]
Subject: Re: [PATCH] Let 'make help' output info about includecheck

On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote:
>From: Jesper Juhl <[email protected]>
>
>'make includecheck' is useful and we want people to run it, so
>let 'make help' output information about its existence.
>
>
>Signed-off-by: Jesper Juhl <[email protected]>

I think Randy Dunlap has done this[1]. ;)

[1] http://lkml.org/lkml/2007/11/4/120

Regards.


Cong

2007-11-14 09:16:31

by Jesper Juhl

[permalink] [raw]
Subject: Re: [PATCH] Let 'make help' output info about includecheck

On 14/11/2007, WANG Cong <[email protected]> wrote:
> On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote:
> >From: Jesper Juhl <[email protected]>
> >
> >'make includecheck' is useful and we want people to run it, so
> >let 'make help' output information about its existence.
> >
> >
> >Signed-off-by: Jesper Juhl <[email protected]>
>
> I think Randy Dunlap has done this[1]. ;)
>
> [1] http://lkml.org/lkml/2007/11/4/120
>

So it would seem.
I just looked in the latest git tree and noticed it was missing. I
didn't hunt for existing patches that fixed it.
Thank you for pointing it out.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html