2007-11-14 12:25:54

by B. N. Poornima

[permalink] [raw]
Subject: Re: [PATCH] prom_find_machine_type typo breaks pSeries lpar boot

Benjamin Herrenschmidt wrote:
> On Fri, 2005-06-03 at 14:25 -0500, Nathan Lynch wrote:
>
>> Typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
>> result code handling in prom_init" prevents pSeries LPAR systems from
>> booting.
>>
>> Tested on a pSeries 570 and OpenPower 720 (both Power5 LPAR).
>>
>
> Damn ! I'm certain I tested it on P5 ! I must have forgotten to "quilt
> ref" before sending the patch (as I did notice this typo and fixed it
> just before sending).
>
> Sorry!
>
> Ben.
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
Hello,
Same typo has creped in again from 2.6.17 kernel onwards and causing
open firmware exception in pSeries systems.
=====================================================================================

Welcome to yaboot version 10.1.21-r910.SuSE
booted from '/vdevice/v-scsi@30000003/disk@8100000000000000'
Enter "help" to get some basic usage information
boot: 2.6.23.1
Please wait, loading kernel...
Allocated 03500000 bytes for kernel @ 01c00000
Elf64 kernel loaded...
Loading ramdisk...
ramdisk loaded 0020d000 @ 06b00000
DEFAULT CATCH!, exception-handler=fff00300
at %SRR0: c00000000202705c %SRR1: 8000000000003002
Open Firmware exception handler entered from non-OF code

Client's Fix Pt Regs:
00 0223100003080000 00000000018bfac0 0000000004bbeaf8 00000000018bfb48
04 00000000018bfc90 0000000000c39a48 0000000000000000 5c3a03080000a0fa
08 0000000000000001 0000000000000000 05910000194c0223 000000005cae0000
0c 0000000003f1eaf8 0000000000000000 0000000000000000 0000000000000000
10 0000000000000000 0000000000c39a48 0000000000000000 00000000018bfc90
14 0000000000c00000 000000000020d000 0000000000000000 0000000008b00000
18 0000000000280004 00000000018bff04 0000000000000001 0000000000000000
1c 0000000008b00000 0000000000c39a48 c000000004d1e530 0000000008b00000
Special Regs:
%IV: 00000300 %CR: 44000028 %XER: 00000000 %DSISR: 08000000
%SRR0: c00000000202705c %SRR1: 8000000000003002
%LR: c000000002027428 %CTR: c0000000020273f0
%DAR: 05910000194c02eb
Virtual PID = 0
PFW: Unable to send error log!
ofdbg
0 >

===========================================================================================
The patch that is provided solves the problem.

Regards,
Poornima.


2007-11-14 19:38:26

by Nathan Lynch

[permalink] [raw]
Subject: Re: [PATCH] prom_find_machine_type typo breaks pSeries lpar boot

Hi-

B. N. Poornima wrote:
> >On Fri, 2005-06-03 at 14:25 -0500, Nathan Lynch wrote:
> >
> >>Typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
> >>result code handling in prom_init" prevents pSeries LPAR systems from
> >>booting.
> >>
>
> Hello,
> Same typo has creped in again from 2.6.17 kernel onwards and causing
> open firmware exception in pSeries systems.

Looking at the current code, I don't see how this analysis could be
correct.

> The patch that is provided solves the problem.

Which patch? Did you forget to include it?

It would be best if you sent your problem report and any patches to
[email protected]. linuxppc64-dev is dead.

Thanks.

2007-11-14 22:27:15

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [PATCH] prom_find_machine_type typo breaks pSeries lpar boot


On Wed, 2007-11-14 at 17:57 +0530, B. N. Poornima wrote:
> Benjamin Herrenschmidt wrote:
> > On Fri, 2005-06-03 at 14:25 -0500, Nathan Lynch wrote:
> >
> >> Typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
> >> result code handling in prom_init" prevents pSeries LPAR systems from
> >> booting.
> >>
> >> Tested on a pSeries 570 and OpenPower 720 (both Power5 LPAR).
> >>
> >
> > Damn ! I'm certain I tested it on P5 ! I must have forgotten to "quilt
> > ref" before sending the patch (as I did notice this typo and fixed it
> > just before sending).
> >
> > Sorry!
> >
> > Ben.
> >
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
> >
> >
> Hello,
> Same typo has creped in again from 2.6.17 kernel onwards and causing
> open firmware exception in pSeries systems.

Can you forward the patch ?

> =====================================================================================
>
> Welcome to yaboot version 10.1.21-r910.SuSE
> booted from '/vdevice/v-scsi@30000003/disk@8100000000000000'
> Enter "help" to get some basic usage information
> boot: 2.6.23.1
> Please wait, loading kernel...
> Allocated 03500000 bytes for kernel @ 01c00000
> Elf64 kernel loaded...
> Loading ramdisk...
> ramdisk loaded 0020d000 @ 06b00000
> DEFAULT CATCH!, exception-handler=fff00300
> at %SRR0: c00000000202705c %SRR1: 8000000000003002
> Open Firmware exception handler entered from non-OF code
>
> Client's Fix Pt Regs:
> 00 0223100003080000 00000000018bfac0 0000000004bbeaf8 00000000018bfb48
> 04 00000000018bfc90 0000000000c39a48 0000000000000000 5c3a03080000a0fa
> 08 0000000000000001 0000000000000000 05910000194c0223 000000005cae0000
> 0c 0000000003f1eaf8 0000000000000000 0000000000000000 0000000000000000
> 10 0000000000000000 0000000000c39a48 0000000000000000 00000000018bfc90
> 14 0000000000c00000 000000000020d000 0000000000000000 0000000008b00000
> 18 0000000000280004 00000000018bff04 0000000000000001 0000000000000000
> 1c 0000000008b00000 0000000000c39a48 c000000004d1e530 0000000008b00000
> Special Regs:
> %IV: 00000300 %CR: 44000028 %XER: 00000000 %DSISR: 08000000
> %SRR0: c00000000202705c %SRR1: 8000000000003002
> %LR: c000000002027428 %CTR: c0000000020273f0
> %DAR: 05910000194c02eb
> Virtual PID = 0
> PFW: Unable to send error log!
> ofdbg
> 0 >
>
> ===========================================================================================
> The patch that is provided solves the problem.
>
> Regards,
> Poornima.

2007-11-16 10:38:03

by B. N. Poornima

[permalink] [raw]
Subject: Re: [PATCH] prom_find_machine_type typo breaks pSeries lpar boot

Nathan Lynch wrote:
> Hi-
>
> B. N. Poornima wrote:
>
>>> On Fri, 2005-06-03 at 14:25 -0500, Nathan Lynch wrote:
>>>
>>>
>>>> Typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
>>>> result code handling in prom_init" prevents pSeries LPAR systems from
>>>> booting.
>>>>
>>>>
>> Hello,
>> Same typo has creped in again from 2.6.17 kernel onwards and causing
>> open firmware exception in pSeries systems.
>>
>
> Looking at the current code, I don't see how this analysis could be
> correct.
>
You are right. Sorry for the confusion. I had overlooked the changes
in the code (prom_init.c) Will check if
the problem still persists on the latest version. Thanks!
>
>> The patch that is provided solves the problem.
>>
>
> Which patch? Did you forget to include it?
>
> It would be best if you sent your problem report and any patches to
> [email protected]. linuxppc64-dev is dead.
>
> Thanks.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>