2007-11-19 15:14:27

by Alan

Subject: [PATCH] 21285: Report baud rate back via termios

Currently reports back the requested rate not the result of the divides
but thats an easy fix for someone with h/w

Signed-off-by: Alan Cox <[email protected]>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c linux-2.6.24-rc2-mm1/drivers/serial/21285.c
--- linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c 2007-11-16 17:20:48.000000000 +0000
+++ linux-2.6.24-rc2-mm1/drivers/serial/21285.c 2007-11-16 18:35:29.000000000 +0000
@@ -277,6 +279,8 @@
if (termios->c_iflag & INPCK)
port->read_status_mask |= RXSTAT_FRAME | RXSTAT_PARITY;

+ tty_encode_baud_rate(tty, baud, baud);
+
/*
* Which character status flags should we ignore?
*/
@@ -301,6 +305,7 @@
*CSR_UARTCON = 1;

spin_unlock_irqrestore(&port->lock, flags);
+
}

static const char *serial21285_type(struct uart_port *port)

2007-11-19 15:42:19

by Russell King

Subject: Re: [PATCH] 21285: Report baud rate back via termios

On Mon, Nov 19, 2007 at 03:12:22PM +0000, Alan Cox wrote:
> Currently reports back the requested rate not the result of the divides
> but thats an easy fix for someone with h/w
>
> Signed-off-by: Alan Cox <[email protected]>

Ack for first hunk. When can this be merged? I assume it has to wait
for tty_encode_baud_rate() to appear in mainline?

> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c linux-2.6.24-rc2-mm1/drivers/serial/21285.c
> --- linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c 2007-11-16 17:20:48.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/drivers/serial/21285.c 2007-11-16 18:35:29.000000000 +0000
> @@ -277,6 +279,8 @@
> if (termios->c_iflag & INPCK)
> port->read_status_mask |= RXSTAT_FRAME | RXSTAT_PARITY;
>
> + tty_encode_baud_rate(tty, baud, baud);
> +
> /*
> * Which character status flags should we ignore?
> */
> @@ -301,6 +305,7 @@
> *CSR_UARTCON = 1;
>
> spin_unlock_irqrestore(&port->lock, flags);
> +
> }
>
> static const char *serial21285_type(struct uart_port *port)

This hunk isn't required.

Note also that no one reads [email protected].

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:

2007-11-19 15:52:18

by Alan

Subject: Re: [PATCH] 21285: Report baud rate back via termios

On Mon, 19 Nov 2007 15:41:37 +0000
Russell King <[email protected]> wrote:

> On Mon, Nov 19, 2007 at 03:12:22PM +0000, Alan Cox wrote:
> > Currently reports back the requested rate not the result of the divides
> > but thats an easy fix for someone with h/w
> >
> > Signed-off-by: Alan Cox <[email protected]>
>
> Ack for first hunk. When can this be merged? I assume it has to wait
> for tty_encode_baud_rate() to appear in mainline?

tty_termios_encode_baud-rate/tty_encode_baud_rate are now in mainline

2007-11-19 15:55:36

by Russell King

Subject: Re: [PATCH] 21285: Report baud rate back via termios

On Mon, Nov 19, 2007 at 03:50:07PM +0000, Alan Cox wrote:
> On Mon, 19 Nov 2007 15:41:37 +0000
> Russell King <[email protected]> wrote:
>
> > On Mon, Nov 19, 2007 at 03:12:22PM +0000, Alan Cox wrote:
> > > Currently reports back the requested rate not the result of the divides
> > > but thats an easy fix for someone with h/w
> > >
> > > Signed-off-by: Alan Cox <[email protected]>
> >
> > Ack for first hunk. When can this be merged? I assume it has to wait
> > for tty_encode_baud_rate() to appear in mainline?
>
> tty_termios_encode_baud-rate/tty_encode_baud_rate are now in mainline

Great, I'll queue it for the next merge minus the 2nd hunk.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: