2007-11-28 19:26:19

by Hugh Dickins

Subject: [PATCH -mm] printk trivial optimizations fix

mm's printk has been showing "%p" in abominable upper case recently:
its trivial optimizations have changed the default from lower to upper,
so the 'p' case needs to enforce lower explicitly.

Signed-off-by: Hugh Dickins <[email protected]>
---

lib/vsprintf.c | 1 +
1 file changed, 1 insertion(+)

--- 2.6.24-rc3-mm2/lib/vsprintf.c 2007-11-28 12:42:26.000000000 +0000
+++ linux/lib/vsprintf.c 2007-11-28 17:01:20.000000000 +0000
@@ -525,6 +525,7 @@ int vsnprintf(char *buf, size_t size, co
continue;

case 'p':
+ flags |= SMALL;
if (field_width == -1) {
field_width = 2*sizeof(void *);
flags |= ZEROPAD;

2007-11-29 04:06:34

by Denys Vlasenko

Subject: Re: [PATCH -mm] printk trivial optimizations fix

On Wednesday 28 November 2007 11:02, Hugh Dickins wrote:
> mm's printk has been showing "%p" in abominable upper case recently:
> its trivial optimizations have changed the default from lower to upper,
> so the 'p' case needs to enforce lower explicitly.
>
> Signed-off-by: Hugh Dickins <[email protected]>
> ---
>
> lib/vsprintf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- 2.6.24-rc3-mm2/lib/vsprintf.c 2007-11-28 12:42:26.000000000 +0000
> +++ linux/lib/vsprintf.c 2007-11-28 17:01:20.000000000 +0000
> @@ -525,6 +525,7 @@ int vsnprintf(char *buf, size_t size, co
> continue;
>
> case 'p':
> + flags |= SMALL;
> if (field_width == -1) {
> field_width = 2*sizeof(void *);
> flags |= ZEROPAD;

Thanks Hugh for catching this. My fault :(
--
vda