2007-12-05 18:36:44

by Oleg Nesterov

[permalink] [raw]
Subject: [PATCH -mm] sys_setsid: remove now unneeded session != 1 check

Eric's "fix clone(CLONE_NEWPID)" eliminated the last reason for this hack.

Signed-off-by: Oleg Nesterov <[email protected]>

--- PT/kernel/sys.c~ 2007-11-27 16:58:38.000000000 +0300
+++ PT/kernel/sys.c 2007-12-05 21:31:53.000000000 +0300
@@ -1056,11 +1056,8 @@ asmlinkage long sys_setsid(void)

/* Fail if a process group id already exists that equals the
* proposed session id.
- *
- * Don't check if session == 1, clone(CLONE_NEWPID) creates
- * this group/session beforehand.
*/
- if (session != 1 && pid_task(sid, PIDTYPE_PGID))
+ if (pid_task(sid, PIDTYPE_PGID))
goto out;

group_leader->signal->leader = 1;