2007-12-10 19:31:07

by Richard Knutsson

Subject: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Remove local definition of TRUE/FALSE.

Signed-off-by: Richard Knutsson <[email protected]>
---


diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h
index d5d092c..4484778 100644
--- a/drivers/net/ipg.h
+++ b/drivers/net/ipg.h
@@ -490,38 +490,34 @@ enum ipg_regs {
* Tune
*/

-/* Miscellaneous Constants. */
-#define TRUE 1
-#define FALSE 0
-
/* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS append on TX. */
-#define IPG_APPEND_FCS_ON_TX TRUE
+#define IPG_APPEND_FCS_ON_TX true

/* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS strip on RX. */
-#define IPG_STRIP_FCS_ON_RX TRUE
+#define IPG_STRIP_FCS_ON_RX true

/* Assign IPG_DROP_ON_RX_ETH_ERRORS > 0 to drop RX frames with
* Ethernet errors.
*/
-#define IPG_DROP_ON_RX_ETH_ERRORS TRUE
+#define IPG_DROP_ON_RX_ETH_ERRORS true

/* Assign IPG_INSERT_MANUAL_VLAN_TAG > 0 to insert VLAN tags manually
* (via TFC).
*/
-#define IPG_INSERT_MANUAL_VLAN_TAG FALSE
+#define IPG_INSERT_MANUAL_VLAN_TAG false

/* Assign IPG_ADD_IPCHECKSUM_ON_TX > 0 for auto IP checksum on TX. */
-#define IPG_ADD_IPCHECKSUM_ON_TX FALSE
+#define IPG_ADD_IPCHECKSUM_ON_TX false

/* Assign IPG_ADD_TCPCHECKSUM_ON_TX > 0 for auto TCP checksum on TX.
* DO NOT USE FOR SILICON REVISIONS B3 AND EARLIER.
*/
-#define IPG_ADD_TCPCHECKSUM_ON_TX FALSE
+#define IPG_ADD_TCPCHECKSUM_ON_TX false

/* Assign IPG_ADD_UDPCHECKSUM_ON_TX > 0 for auto UDP checksum on TX.
* DO NOT USE FOR SILICON REVISIONS B3 AND EARLIER.
*/
-#define IPG_ADD_UDPCHECKSUM_ON_TX FALSE
+#define IPG_ADD_UDPCHECKSUM_ON_TX false

/* If inserting VLAN tags manually, assign the IPG_MANUAL_VLAN_xx
* constants as desired.

2007-12-10 19:54:29

by Pekka Enberg

Subject: Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Hi Richard,

On Dec 10, 2007 9:29 PM, Richard Knutsson <[email protected]> wrote:
> Remove local definition of TRUE/FALSE.

This is already fixed in Francois' tree:

http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h=2af61e99e3d1c959840ea007ff56b15db794fb99

Pekka

2007-12-10 20:08:46

by Richard Knutsson

Subject: Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Pekka Enberg wrote:
> Hi Richard,
>
> On Dec 10, 2007 9:29 PM, Richard Knutsson <[email protected]> wrote:
>
>> Remove local definition of TRUE/FALSE.
>>
>
> This is already fixed in Francois' tree:
>
> http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h=2af61e99e3d1c959840ea007ff56b15db794fb99
>
I see, thanks.

Richard Knutsson