2008-01-06 14:02:15

by Jörn Engel

[permalink] [raw]
Subject: [PATCH] Claim maintainership for block2mtd and update email addresses

I have been prime author and maintainer of block2mtd from day one, but
neither MAINTAINERS nor the module source makes this fact clear. And while
I'm at it, update my email addresses tree-wide, as the old address currently
bounces and change my name to "joern" as unicode will likely continue to
cause trouble until the end of this century.

Signed-off-by: Jörn Engel <[email protected]>
---

MAINTAINERS | 10 ++++++++--
drivers/mtd/devices/block2mtd.c | 4 ++--
drivers/mtd/devices/phram.c | 4 ++--
drivers/mtd/maps/mtx-1_flash.c | 2 +-
scripts/checkstack.pl | 2 +-
5 files changed, 14 insertions(+), 8 deletions(-)

--- linux-2.6.24-rc3logfs/drivers/mtd/devices/block2mtd.c~block2mtd_maintainer 2007-08-08 19:30:04.000000000 +0200
+++ linux-2.6.24-rc3logfs/drivers/mtd/devices/block2mtd.c 2008-01-06 14:22:57.000000000 +0100
@@ -4,7 +4,7 @@
* block2mtd.c - create an mtd from a block device
*
* Copyright (C) 2001,2002 Simon Evans <[email protected]>
- * Copyright (C) 2004-2006 Jörn Engel <[email protected]>
+ * Copyright (C) 2004-2006 Joern Engel <[email protected]>
*
* Licence: GPL
*/
@@ -485,5 +485,5 @@ module_init(block2mtd_init);
module_exit(block2mtd_exit);

MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Simon Evans <[email protected]> and others");
+MODULE_AUTHOR("Joern Engel <[email protected]>");
MODULE_DESCRIPTION("Emulate an MTD using a block device");
--- linux-2.6.24-rc3logfs/MAINTAINERS~block2mtd_maintainer 2007-11-30 13:59:51.000000000 +0100
+++ linux-2.6.24-rc3logfs/MAINTAINERS 2008-01-06 14:21:49.000000000 +0100
@@ -835,6 +835,12 @@ L: [email protected]
T: git kernel.org:/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git
S: Maintained

+BLOCK2MTD DRIVER
+P: Joern Engel
+M: [email protected]
+L: [email protected]
+S: Maintained
+
BLUETOOTH SUBSYSTEM
P: Marcel Holtmann
M: [email protected]
@@ -2985,8 +2991,8 @@ L: [email protected]
S: Maintained

PHRAM MTD DRIVER
-P: Jörn Engel
-M: [email protected]
+P: Joern Engel
+M: [email protected]
L: [email protected]
S: Maintained

--- linux-2.6.24-rc3logfs/drivers/mtd/devices/phram.c~block2mtd_maintainer 2007-08-08 19:30:04.000000000 +0200
+++ linux-2.6.24-rc3logfs/drivers/mtd/devices/phram.c 2008-01-06 14:22:30.000000000 +0100
@@ -2,7 +2,7 @@
* $Id: phram.c,v 1.16 2005/11/07 11:14:25 gleixner Exp $
*
* Copyright (c) ???? Jochen Schäuble <[email protected]>
- * Copyright (c) 2003-2004 Jörn Engel <[email protected]>
+ * Copyright (c) 2003-2004 Joern Engel <[email protected]>
*
* Usage:
*
@@ -299,5 +299,5 @@ module_init(init_phram);
module_exit(cleanup_phram);

MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Jörn Engel <[email protected]>");
+MODULE_AUTHOR("Joern Engel <[email protected]>");
MODULE_DESCRIPTION("MTD driver for physical RAM");
--- linux-2.6.24-rc3logfs/scripts/checkstack.pl~block2mtd_maintainer 2007-11-15 20:52:00.000000000 +0100
+++ linux-2.6.24-rc3logfs/scripts/checkstack.pl 2008-01-06 14:28:14.000000000 +0100
@@ -2,7 +2,7 @@

# Check the stack usage of functions
#
-# Copyright Joern Engel <[email protected]>
+# Copyright Joern Engel <[email protected]>
# Inspired by Linus Torvalds
# Original idea maybe from Keith Owens
# s390 port and big speedup by Arnd Bergmann <[email protected]>
--- linux-2.6.24-rc3logfs/drivers/mtd/maps/mtx-1_flash.c~block2mtd_maintainer 2007-08-08 19:30:04.000000000 +0200
+++ linux-2.6.24-rc3logfs/drivers/mtd/maps/mtx-1_flash.c 2008-01-06 14:28:44.000000000 +0100
@@ -4,7 +4,7 @@
* $Id: mtx-1_flash.c,v 1.2 2005/11/07 11:14:27 gleixner Exp $
*
* (C) 2005 Bruno Randolf <[email protected]>
- * (C) 2005 Jörn Engel <[email protected]>
+ * (C) 2005 Joern Engel <[email protected]>
*
*/


2008-01-07 23:23:34

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Claim maintainership for block2mtd and update email addresses

On Sun, 6 Jan 2008 14:56:01 +0100
J__rn Engel <[email protected]> wrote:

> - * Copyright (C) 2004-2006 Jörn Engel <[email protected]>
> + * Copyright (C) 2004-2006 Joern Engel <[email protected]>

Yup. Your name comes out like that when sylpheed does its
save-email-to-a-file thing as well and I haven't got around to working out
why, or to reporting it.

In this case it looks like the dud characters came about due to "[MTD] Fix
legacy character sets throughout drivers/mtd, include/linux/mtd". Which
doesn't look like it fixed anything much really.

Going with the asciified/anglicised/bastardised spelling is a practical
(albeit unhappy) solution.

2008-01-08 01:13:10

by Jörn Engel

[permalink] [raw]
Subject: Re: [PATCH] Claim maintainership for block2mtd and update email addresses

On Mon, 7 January 2008 15:23:00 -0800, Andrew Morton wrote:
> On Sun, 6 Jan 2008 14:56:01 +0100
> J__rn Engel <[email protected]> wrote:

You found a new one! That make a round dozen, I believe.
http://logfs.org/logfs/joern

> > - * Copyright (C) 2004-2006 Jörn Engel <[email protected]>
> > + * Copyright (C) 2004-2006 Joern Engel <[email protected]>
>
> Yup. Your name comes out like that when sylpheed does its
> save-email-to-a-file thing as well and I haven't got around to working out
> why, or to reporting it.
>
> In this case it looks like the dud characters came about due to "[MTD] Fix
> legacy character sets throughout drivers/mtd, include/linux/mtd". Which
> doesn't look like it fixed anything much really.
>
> Going with the asciified/anglicised/bastardised spelling is a practical
> (albeit unhappy) solution.

I'm happy if people spend effort and make unicode work. Until then I'll
semi-officially change my name to "Joern" and keep collecting unusual
specimens.

Jörn

--
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike

2008-01-08 23:23:32

by Guennadi Liakhovetski

[permalink] [raw]
Subject: Re: [PATCH] Claim maintainership for block2mtd and update email addresses

On Tue, 8 Jan 2008, Jörn Engel wrote:

> I'm happy if people spend effort and make unicode work. Until then I'll
> semi-officially change my name to "Joern" and keep collecting unusual
> specimens.

Just wondering - nothing personal at all. What's the official plan for
this - do we want (when utf8 works) to use utf8 codes for symbols only for
languages mostly based on ASCII, like iso-8859-15, or for all? Would we,
for example, then also write Cyrillic names in utf-8 and every other
alphabet for that matter? Didn't find anything under Documentation about
that. Maybe we want to document it somewhere? Wasn't C-sources originally
supposed to be ASCII? So, what we use in sources, what under Documentation
or in MAINTAINERS may be different matters?

Thanks
Guennadi
---
Guennadi Liakhovetski

2008-01-09 00:53:22

by David Brown

[permalink] [raw]
Subject: Re: [PATCH] Claim maintainership for block2mtd and update email addresses

On Wed, Jan 09, 2008 at 12:23:24AM +0100, Guennadi Liakhovetski wrote:

>On Tue, 8 Jan 2008, Jörn Engel wrote:
>
>> I'm happy if people spend effort and make unicode work. Until then I'll
>> semi-officially change my name to "Joern" and keep collecting unusual
>> specimens.
>
>Just wondering - nothing personal at all. What's the official plan for
>this - do we want (when utf8 works) to use utf8 codes for symbols only for
>languages mostly based on ASCII, like iso-8859-15, or for all?

UTF-8 already works fine in git. There is some support in recent versions
to allow commit messages and users to be specified in other encodings.

I think the issue here is with mailers modifying the encoding of data in
message files.

My reply header should be to Jörn, with a proper 'o' with two dots over it.
By default, my mailer wants to encode the message in iso-8859-1. If I add
a single unicode character, say '‣', then the whole message will get
encoded in UTF-8.

UTF-8 has the advantage of supporting nearly all character sets. The extra
space needed isn't really an issue for usernames or for comment messages.

Dave

2008-01-09 00:53:37

by David Brown

[permalink] [raw]
Subject: Re: [PATCH] Claim maintainership for block2mtd and update email addresses

On Wed, Jan 09, 2008 at 12:23:24AM +0100, Guennadi Liakhovetski wrote:

>On Tue, 8 Jan 2008, Jörn Engel wrote:
>
>> I'm happy if people spend effort and make unicode work. Until then I'll
>> semi-officially change my name to "Joern" and keep collecting unusual
>> specimens.
>
>Just wondering - nothing personal at all. What's the official plan for
>this - do we want (when utf8 works) to use utf8 codes for symbols only for
>languages mostly based on ASCII, like iso-8859-15, or for all?

UTF-8 already works fine in git. There is some support in recent versions
to allow commit messages and users to be specified in other encodings.

I think the issue here is with mailers modifying the encoding of data in
message files.

My reply header should be to Jörn, with a proper 'o' with two dots over it.
By default, my mailer wants to encode the message in iso-8859-1. If I add
a single unicode character, say '‣', then the whole message will get
encoded in UTF-8.

UTF-8 has the advantage of supporting nearly all character sets. The extra
space needed isn't really an issue for usernames or for comment messages.

Dave