2008-01-29 00:17:32

by Gaston, Jason D

[permalink] [raw]
Subject: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's

This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

Signed-off-by: Jason Gaston <[email protected]>

--- linux-2.6.24/include/linux/pci_ids.h.orig 2008-01-24 14:58:37.000000000 -0800
+++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28 15:05:41.000000000 -0800
@@ -2339,6 +2339,12 @@
#define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
#define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
#define PCI_DEVICE_ID_INTEL_IOAT_CNB 0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_0 0x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_1 0x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_2 0x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a
+#define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60
#define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
#define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff
#define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031


2008-01-29 00:21:59

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's

On Mon, Jan 28, 2008 at 05:20:36PM -0800, Jason Gaston wrote:
> This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

Jason,
two questions:
Have you submitted these to pciids.sf.net?
Where are these used in the kernel?

thanks,
grant

>
> Signed-off-by: Jason Gaston <[email protected]>
>
> --- linux-2.6.24/include/linux/pci_ids.h.orig 2008-01-24 14:58:37.000000000 -0800
> +++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28 15:05:41.000000000 -0800
> @@ -2339,6 +2339,12 @@
> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
> #define PCI_DEVICE_ID_INTEL_IOAT_CNB 0x360b
> +#define PCI_DEVICE_ID_INTEL_ICH10_0 0x3a14
> +#define PCI_DEVICE_ID_INTEL_ICH10_1 0x3a16
> +#define PCI_DEVICE_ID_INTEL_ICH10_2 0x3a18
> +#define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a
> +#define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30
> +#define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60
> #define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
> #define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff
> #define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031

2008-01-29 00:38:22

by Gaston, Jason D

[permalink] [raw]
Subject: RE: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's

>-----Original Message-----
>From: Grant Grundler [mailto:[email protected]]
>Sent: Monday, January 28, 2008 4:22 PM
>To: Gaston, Jason D
>Cc: [email protected]; [email protected]; linux-
>[email protected]; [email protected]; [email protected]
>Subject: Re: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's
>
>On Mon, Jan 28, 2008 at 05:20:36PM -0800, Jason Gaston wrote:
>> This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.
>
>Jason,
>two questions:
>Have you submitted these to pciids.sf.net?
>Where are these used in the kernel?
>
>thanks,
>grant
>
>>
>> Signed-off-by: Jason Gaston <[email protected]>
>>
>> --- linux-2.6.24/include/linux/pci_ids.h.orig 2008-01-24
>14:58:37.000000000 -0800
>> +++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28
>15:05:41.000000000 -0800
>> @@ -2339,6 +2339,12 @@
>> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
>> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
>> #define PCI_DEVICE_ID_INTEL_IOAT_CNB 0x360b
>> +#define PCI_DEVICE_ID_INTEL_ICH10_0 0x3a14
>> +#define PCI_DEVICE_ID_INTEL_ICH10_1 0x3a16
>> +#define PCI_DEVICE_ID_INTEL_ICH10_2 0x3a18
>> +#define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a
>> +#define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30
>> +#define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60
>> #define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
>> #define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff
>> #define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031

Yes, these have been submitted to pciids.sf.net. I am also in the
process up updating the pci.ids strings by adding "ICH10" to them.

These pci_ids.h entries are used in the drivers/i2c/busses/i2c-i801.c
driver and the /arch/x86/pci/irq.c file.

Thank you,

Jason

2008-02-12 09:04:06

by Jean Delvare

[permalink] [raw]
Subject: Re: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's

On Mon, 28 Jan 2008 17:20:36 -0800, Jason Gaston wrote:
> This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.
>
> Signed-off-by: Jason Gaston <[email protected]>
>
> --- linux-2.6.24/include/linux/pci_ids.h.orig 2008-01-24 14:58:37.000000000 -0800
> +++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28 15:05:41.000000000 -0800
> @@ -2339,6 +2339,12 @@
> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
> #define PCI_DEVICE_ID_INTEL_IOAT_CNB 0x360b
> +#define PCI_DEVICE_ID_INTEL_ICH10_0 0x3a14
> +#define PCI_DEVICE_ID_INTEL_ICH10_1 0x3a16
> +#define PCI_DEVICE_ID_INTEL_ICH10_2 0x3a18
> +#define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a
> +#define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30
> +#define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60
> #define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
> #define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff
> #define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031

Greg, please pick this patch quickly so that it makes it to -mm and the
other patches that depend on it can be pushed there as well.

Thanks,
--
Jean Delvare

2008-02-12 15:29:34

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's

On Tue, Feb 12, 2008 at 10:03:38AM +0100, Jean Delvare wrote:
> On Mon, 28 Jan 2008 17:20:36 -0800, Jason Gaston wrote:
> > This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.
> >
> > Signed-off-by: Jason Gaston <[email protected]>
> >
> > --- linux-2.6.24/include/linux/pci_ids.h.orig 2008-01-24 14:58:37.000000000 -0800
> > +++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28 15:05:41.000000000 -0800
> > @@ -2339,6 +2339,12 @@
> > #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
> > #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
> > #define PCI_DEVICE_ID_INTEL_IOAT_CNB 0x360b
> > +#define PCI_DEVICE_ID_INTEL_ICH10_0 0x3a14
> > +#define PCI_DEVICE_ID_INTEL_ICH10_1 0x3a16
> > +#define PCI_DEVICE_ID_INTEL_ICH10_2 0x3a18
> > +#define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a
> > +#define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30
> > +#define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60
> > #define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
> > #define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff
> > #define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031
>
> Greg, please pick this patch quickly so that it makes it to -mm and the
> other patches that depend on it can be pushed there as well.

Will do, give me a few hours...

thanks,

greg k-h