2008-01-28 23:12:09

by Paolo Ciarrocchi

Subject: [PATCH 7/7] fix lines over 80 characters

fix lines over 80 characters

Signed-off-by: Paolo Ciarrocchi <[email protected]>
---
arch/x86/math-emu/errors.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index 569a62e..e5a5b80 100644
--- a/arch/x86/math-emu/errors.c
+++ b/arch/x86/math-emu/errors.c
@@ -75,7 +75,8 @@ void FPU_printall(void)
FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);

if (FPU_modrm >= 0300)
- printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
+ printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
+ FPU_modrm & 7);
else
printk(KERN_ERR " /%d, mod=%d rm=%d\n",
(FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
@@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);

if (n == EX_INTERNAL) {
- printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
+ printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
+ int_type);
FPU_printall();
}
#ifdef PRINT_MESSAGES
--
1.5.4.rc3

2008-01-29 12:46:18

by Stefan Richter

Subject: Re: [PATCH 7/7] fix lines over 80 characters

Paolo Ciarrocchi wrote:
> --- a/arch/x86/math-emu/errors.c
> +++ b/arch/x86/math-emu/errors.c
> @@ -75,7 +75,8 @@ void FPU_printall(void)
> FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
>
> if (FPU_modrm >= 0300)
> - printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
> + printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> + FPU_modrm & 7);
> else
> printk(KERN_ERR " /%d, mod=%d rm=%d\n",
> (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
> @@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
> printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
>
> if (n == EX_INTERNAL) {
> - printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
> + printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> + int_type);
> FPU_printall();
> }
> #ifdef PRINT_MESSAGES


The "fix" is still not conforming to CodingStyle.

Besides, why don't you leave these lines as they are? There is no
important information hidden behind the 80th column in the existing code.
--
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/

2008-01-31 22:54:28

by Paolo Ciarrocchi

Subject: Re: [PATCH 7/7] fix lines over 80 characters

On 1/29/08, Stefan Richter <[email protected]> wrote:
> Paolo Ciarrocchi wrote:
> > --- a/arch/x86/math-emu/errors.c
> > +++ b/arch/x86/math-emu/errors.c
> > @@ -75,7 +75,8 @@ void FPU_printall(void)
> > FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
> >
> > if (FPU_modrm >= 0300)
> > - printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> FPU_modrm & 7);
> > + printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> > + FPU_modrm & 7);
> > else
> > printk(KERN_ERR " /%d, mod=%d rm=%d\n",
> > (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
> > @@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
> > printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
> >
> > if (n == EX_INTERNAL) {
> > - printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> int_type);
> > + printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> > + int_type);
> > FPU_printall();
> > }
> > #ifdef PRINT_MESSAGES
>
>
> The "fix" is still not conforming to CodingStyle.
>
> Besides, why don't you leave these lines as they are? There is no
> important information hidden behind the 80th column in the existing code.


Yes, you are right.
Ingo, patch 7 deserves to be deleted.

Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/