2008-01-30 10:13:40

by Geert Uytterhoeven

[permalink] [raw]
Subject: kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
lib/Kconfig.debug | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -90,19 +90,19 @@ config DEBUG_SECTION_MISMATCH
most likely result in an oops.
In the code functions and variables are annotated with
__init, __devinit etc. (see full list in include/linux/init.h)
- which result in the code/data being placed in specific sections.
- The section mismatch anaylsis are always done after a full
+ which results in the code/data being placed in specific sections.
+ The section mismatch analysis is always done after a full
kernel build but enabling this options will in addition
do the following:
- Add the option -fno-inline-functions-called-once to gcc
When inlining a function annotated __init in a non-init
function we would loose the section information and thus
the analysis would not catch the illegal reference.
- This options tell gcc to inline less but will also
+ This option tells gcc to inline less but will also
result in a larger kernel.
- Run the section mismatch analysis for each module/built-in.o
When we run the section mismatch analysis on vmlinux.o we
- looses valueable information about where the mismatch was
+ loose valueable information about where the mismatch was
introduced.
Running the analysis for each module/built-in.o file
will tell where the mismatch happens much closer to the

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619


2008-01-30 16:15:37

by Randy Dunlap

[permalink] [raw]
Subject: Re: kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

On Wed, 30 Jan 2008 11:13:23 +0100 (CET) Geert Uytterhoeven wrote:

> kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> lib/Kconfig.debug | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -90,19 +90,19 @@ config DEBUG_SECTION_MISMATCH
> most likely result in an oops.
> In the code functions and variables are annotated with
> __init, __devinit etc. (see full list in include/linux/init.h)
> - which result in the code/data being placed in specific sections.
> - The section mismatch anaylsis are always done after a full
> + which results in the code/data being placed in specific sections.
> + The section mismatch analysis is always done after a full
> kernel build but enabling this options will in addition

option

> do the following:
> - Add the option -fno-inline-functions-called-once to gcc
> When inlining a function annotated __init in a non-init
> function we would loose the section information and thus

lose

> the analysis would not catch the illegal reference.
> - This options tell gcc to inline less but will also
> + This option tells gcc to inline less but will also
> result in a larger kernel.
> - Run the section mismatch analysis for each module/built-in.o
> When we run the section mismatch analysis on vmlinux.o we
> - looses valueable information about where the mismatch was
> + loose valueable information about where the mismatch was

lose valuable

> introduced.
> Running the analysis for each module/built-in.o file
> will tell where the mismatch happens much closer to the

Thanks. I had a note to myself to do this as well.

---
~Randy

2008-02-02 18:07:04

by Sam Ravnborg

[permalink] [raw]
Subject: Re: kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

On Wed, Jan 30, 2008 at 08:08:11AM -0800, Randy Dunlap wrote:
> On Wed, 30 Jan 2008 11:13:23 +0100 (CET) Geert Uytterhoeven wrote:
>
> > kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied a combined patch - thanks for fixing my bad grammar/spelling.

Sam