2008-01-30 20:08:26

by Adrian Bunk

Subject: [2.6 patch] make b43_mac_{enable,suspend}() static

b43_mac_{enable,suspend}() can now become static.

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/net/wireless/b43/main.c | 4 ++--
drivers/net/wireless/b43/main.h | 3 ---
2 files changed, 2 insertions(+), 5 deletions(-)

e2a91b00d125ed4b60bdf9e37f550aed23d84747
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 88d2c15..360515c 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -2042,7 +2042,7 @@ static void b43_gpio_cleanup(struct b43_wldev *dev)
}

/* http://bcm-specs.sipsolutions.net/EnableMac */
-void b43_mac_enable(struct b43_wldev *dev)
+static void b43_mac_enable(struct b43_wldev *dev)
{
dev->mac_suspended--;
B43_WARN_ON(dev->mac_suspended < 0);
@@ -2066,7 +2066,7 @@ void b43_mac_enable(struct b43_wldev *dev)
}

/* http://bcm-specs.sipsolutions.net/SuspendMAC */
-void b43_mac_suspend(struct b43_wldev *dev)
+static void b43_mac_suspend(struct b43_wldev *dev)
{
int i;
u32 tmp;
diff --git a/drivers/net/wireless/b43/main.h b/drivers/net/wireless/b43/main.h
index 2d52d9d..4397f49 100644
--- a/drivers/net/wireless/b43/main.h
+++ b/drivers/net/wireless/b43/main.h
@@ -102,9 +102,6 @@ void b43_dummy_transmission(struct b43_wldev *dev);

void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags);

-void b43_mac_suspend(struct b43_wldev *dev);
-void b43_mac_enable(struct b43_wldev *dev);
-
void b43_controller_restart(struct b43_wldev *dev, const char *reason);

#define B43_PS_ENABLED (1 << 0) /* Force enable hardware power saving */

2008-01-30 20:35:27

by Michael Büsch

Subject: Re: [2.6 patch] make b43_mac_{enable,suspend}() static

On Wednesday 30 January 2008 21:02:47 Adrian Bunk wrote:
> b43_mac_{enable,suspend}() can now become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Michael Buesch <[email protected]>

> ---
>
> drivers/net/wireless/b43/main.c | 4 ++--
> drivers/net/wireless/b43/main.h | 3 ---
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> e2a91b00d125ed4b60bdf9e37f550aed23d84747
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 88d2c15..360515c 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -2042,7 +2042,7 @@ static void b43_gpio_cleanup(struct b43_wldev *dev)
> }
>
> /* http://bcm-specs.sipsolutions.net/EnableMac */
> -void b43_mac_enable(struct b43_wldev *dev)
> +static void b43_mac_enable(struct b43_wldev *dev)
> {
> dev->mac_suspended--;
> B43_WARN_ON(dev->mac_suspended < 0);
> @@ -2066,7 +2066,7 @@ void b43_mac_enable(struct b43_wldev *dev)
> }
>
> /* http://bcm-specs.sipsolutions.net/SuspendMAC */
> -void b43_mac_suspend(struct b43_wldev *dev)
> +static void b43_mac_suspend(struct b43_wldev *dev)
> {
> int i;
> u32 tmp;
> diff --git a/drivers/net/wireless/b43/main.h b/drivers/net/wireless/b43/main.h
> index 2d52d9d..4397f49 100644
> --- a/drivers/net/wireless/b43/main.h
> +++ b/drivers/net/wireless/b43/main.h
> @@ -102,9 +102,6 @@ void b43_dummy_transmission(struct b43_wldev *dev);
>
> void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags);
>
> -void b43_mac_suspend(struct b43_wldev *dev);
> -void b43_mac_enable(struct b43_wldev *dev);
> -
> void b43_controller_restart(struct b43_wldev *dev, const char *reason);
>
> #define B43_PS_ENABLED (1 << 0) /* Force enable hardware power saving */
>
>
>



--
Greetings Michael.