2008-01-31 15:01:52

by Cong Wang

[permalink] [raw]
Subject: [Patch] include/asm-generic/tlb.h: fix a missing header


This patch fixes this build error in current -git tree:

CC kernel/sched.o
In file included from include/asm/arch/tlb.h:10,
from include/asm/tlb.h:5,
from kernel/sched.c:71:
include/asm-generic/tlb.h: In function 'tlb_finish_mmu':
include/asm-generic/tlb.h:91: error: implicit declaration of function 'check_pgt_cache'
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2


Cc: Ingo Molnar <[email protected]>
Cc: Christoph Lameter <[email protected]>
Signed-off-by: WANG Cong <[email protected]>

---

diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
index 6ce9f3a..4ebbe15 100644
--- a/include/asm-generic/tlb.h
+++ b/include/asm-generic/tlb.h
@@ -16,6 +16,7 @@
#include <linux/swap.h>
#include <linux/quicklist.h>
#include <asm/tlbflush.h>
+#include <asm/pgalloc.h>

/*
* For UP we don't need to worry about TLB flush


2008-01-31 22:08:39

by Christoph Lameter

[permalink] [raw]
Subject: Re: [Patch] include/asm-generic/tlb.h: fix a missing header

On Thu, 31 Jan 2008, WANG Cong wrote:

> index 6ce9f3a..4ebbe15 100644
> --- a/include/asm-generic/tlb.h
> +++ b/include/asm-generic/tlb.h
> @@ -16,6 +16,7 @@
> #include <linux/swap.h>
> #include <linux/quicklist.h>
> #include <asm/tlbflush.h>
> +#include <asm/pgalloc.h>

Please also remove the #include <linux/quicklist.h>. It should have been
part of
a patch
reversal.

2008-02-01 03:48:11

by Cong Wang

[permalink] [raw]
Subject: Re: [Patch] include/asm-generic/tlb.h: fix a missing header

On Thu, Jan 31, 2008 at 02:08:31PM -0800, Christoph Lameter wrote:
>On Thu, 31 Jan 2008, WANG Cong wrote:
>
>> index 6ce9f3a..4ebbe15 100644
>> --- a/include/asm-generic/tlb.h
>> +++ b/include/asm-generic/tlb.h
>> @@ -16,6 +16,7 @@
>> #include <linux/swap.h>
>> #include <linux/quicklist.h>
>> #include <asm/tlbflush.h>
>> +#include <asm/pgalloc.h>
>
>Please also remove the #include <linux/quicklist.h>. It should have been
>part of
>a patch
>reversal.

Please ignore this patch, since Ingo already had the same one.

Thanks!