2008-02-13 03:57:16

by Al Viro

Subject: [PATCH] drivers/memstick/host/tifm_ms.c breakage

readl(sock + ...) that should've been readl(sock->addr + ...)

Signed-off-by: Al Viro <[email protected]>
---
diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
index f55b71a..4fb2421 100644
--- a/drivers/memstick/host/tifm_ms.c
+++ b/drivers/memstick/host/tifm_ms.c
@@ -282,7 +282,7 @@ static int tifm_ms_issue_cmd(struct tifm_ms *host)

writel(TIFM_MS_SYS_LATCH
| readl(sock->addr + SOCK_MS_SYSTEM),
- sock + SOCK_MS_SYSTEM);
+ sock->addr + SOCK_MS_SYSTEM);
writel(0, sock->addr + SOCK_MS_DATA);
dev_dbg(&sock->dev, "writing %x\n", 0);

2008-02-13 04:11:33

by Al Viro

Subject: Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage

On Wed, Feb 13, 2008 at 03:56:59AM +0000, Al Viro wrote:
> readl(sock + ...) that should've been readl(sock->addr + ...)

s/readl(/writel(..., / in the changelog message...

2008-02-13 05:12:25

by Alex Dubov

Subject: Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage

--- Al Viro <[email protected]> wrote:

> readl(sock + ...) that should've been readl(sock->addr + ...)
>

Thanks. It's a first member in struct, so the problem was just sitting there unnoticed.



____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ