2008-02-13 04:03:35

by Al Viro

Subject: [PATCH] wmi: (!x & y) strikes again

Signed-off-by: Al Viro <[email protected]>
---
d2d6f5b9eb315a53043a722d952bb21ed5ca1229
diff --git a/drivers/acpi/wmi.c b/drivers/acpi/wmi.c
index 457ed3d..efacc9f 100644
--- a/drivers/acpi/wmi.c
+++ b/drivers/acpi/wmi.c
@@ -247,7 +247,7 @@ u32 method_id, const struct acpi_buffer *in, struct acpi_buffer *out)
block = &wblock->gblock;
handle = wblock->handle;

- if (!block->flags & ACPI_WMI_METHOD)
+ if (!(block->flags & ACPI_WMI_METHOD))
return AE_BAD_DATA;

if (block->instance_count < instance)

2008-02-13 07:15:10

by Carlos Corbacho

Subject: Re: [PATCH] wmi: (!x & y) strikes again

On Wednesday 13 February 2008 04:03:25 Al Viro wrote:
> Signed-off-by: Al Viro <[email protected]>

Acked-by: Carlos Corbacho <[email protected]>

> ---
> d2d6f5b9eb315a53043a722d952bb21ed5ca1229
> diff --git a/drivers/acpi/wmi.c b/drivers/acpi/wmi.c
> index 457ed3d..efacc9f 100644
> --- a/drivers/acpi/wmi.c
> +++ b/drivers/acpi/wmi.c
> @@ -247,7 +247,7 @@ u32 method_id, const struct acpi_buffer *in, struct acpi_buffer *out)
> block = &wblock->gblock;
> handle = wblock->handle;
>
> - if (!block->flags & ACPI_WMI_METHOD)
> + if (!(block->flags & ACPI_WMI_METHOD))
> return AE_BAD_DATA;
>
> if (block->instance_count < instance)
>
--
E-Mail: [email protected]
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D