2008-02-13 10:54:26

by Robert P. J. Day

[permalink] [raw]
Subject: Tests of undefined CONFIG variables.


i've also updated the list of what i call "badref" CONFIG variables
-- that is, tests of CONFIG_ variables that appear to be undefined
anywhere in a Kconfig file (which typically represents a meaningless
test, naturally).

http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================


2008-02-13 11:31:23

by Paul Mundt

[permalink] [raw]
Subject: Re: Tests of undefined CONFIG variables.

On Wed, Feb 13, 2008 at 05:54:12AM -0500, Robert P. J. Day wrote:
> i've also updated the list of what i call "badref" CONFIG variables
> -- that is, tests of CONFIG_ variables that appear to be undefined
> anywhere in a Kconfig file (which typically represents a meaningless
> test, naturally).
>
> http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables
>
For SH:

CONFIG_SERIAL
CONFIG_CPU_HAS_PINT_IRQ
CONFIG_LITTLE_ENDIAN
CONFIG_SH64_PROC_TLB

are now fixed, thanks.

2008-02-13 11:35:55

by Robert P. J. Day

[permalink] [raw]
Subject: Re: Tests of undefined CONFIG variables.

On Wed, 13 Feb 2008, Paul Mundt wrote:

> On Wed, Feb 13, 2008 at 05:54:12AM -0500, Robert P. J. Day wrote:
> > i've also updated the list of what i call "badref" CONFIG variables
> > -- that is, tests of CONFIG_ variables that appear to be undefined
> > anywhere in a Kconfig file (which typically represents a meaningless
> > test, naturally).
> >
> > http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables
> >
> For SH:
>
> CONFIG_SERIAL
> CONFIG_CPU_HAS_PINT_IRQ
> CONFIG_LITTLE_ENDIAN
> CONFIG_SH64_PROC_TLB
>
> are now fixed, thanks.

ok, removed.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

2008-02-13 13:35:06

by Haavard Skinnemoen

[permalink] [raw]
Subject: Re: Tests of undefined CONFIG variables.

On Wed, 13 Feb 2008 05:54:12 -0500 (EST)
"Robert P. J. Day" <[email protected]> wrote:

> i've also updated the list of what i call "badref" CONFIG variables
> -- that is, tests of CONFIG_ variables that appear to be undefined
> anywhere in a Kconfig file (which typically represents a meaningless
> test, naturally).

I've fixed BOARD_ATSTK1002_SW2_CUSTOM, thanks. It was a real bug.

As for AP7000_8_BIT_SMC, it is sort-of used. It is part of a choice
menu where the other two choices are used like this:

#if defined(CONFIG_AP700X_32_BIT_SMC)
...
#elif defined(CONFIG_AP700X_16_BIT_SMC)
...
#else
...
#endif

and the #else block covers the only remaining choice, AP700X_8_BIT_SMC.

I can fix it by turning the #else above into an #elif I guess.

Haavard