2008-02-13 21:31:42

by Adrian Bunk

Subject: [2.6 patch] x86: make struct efi_phys static

Thuis patch makes the needlessly global struct efi_phys static.

Signed-off-by: Adrian Bunk <[email protected]>

---
3002c1d384e748f2928823ff4b10ed4d6082dceb
diff --git a/arch/x86/kernel/efi.c b/arch/x86/kernel/efi.c
index 1411324..1211ab2 100644
--- a/arch/x86/kernel/efi.c
+++ b/arch/x86/kernel/efi.c
@@ -54,7 +54,7 @@ EXPORT_SYMBOL(efi);

struct efi_memory_map memmap;

-struct efi efi_phys __initdata;
+static struct efi efi_phys __initdata;
static efi_system_table_t efi_systab __initdata;

static int __init setup_noefi(char *arg)

2008-02-14 02:07:06

by Huang, Ying

Subject: Re: [2.6 patch] x86: make struct efi_phys static

On Wed, 2008-02-13 at 23:29 +0200, Adrian Bunk wrote:
> Thuis patch makes the needlessly global struct efi_phys static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
> 3002c1d384e748f2928823ff4b10ed4d6082dceb
> diff --git a/arch/x86/kernel/efi.c b/arch/x86/kernel/efi.c
> index 1411324..1211ab2 100644
> --- a/arch/x86/kernel/efi.c
> +++ b/arch/x86/kernel/efi.c
> @@ -54,7 +54,7 @@ EXPORT_SYMBOL(efi);
>
> struct efi_memory_map memmap;
>
> -struct efi efi_phys __initdata;
> +static struct efi efi_phys __initdata;
> static efi_system_table_t efi_systab __initdata;
>
> static int __init setup_noefi(char *arg)

Reviewed-by: Huang Ying <[email protected]>

Best Regards,
Huang Ying