2008-02-13 21:38:36

by Adrian Bunk

Subject: [2.6 patch] thinkpad_acpi.c: make 2 functions static

this_patch_makes_the_needlessly_global_hotkey_wakeup_reason_notify_change_and_hotkey_wakeup_hotunplug_complete_notify_change_static

Signed-off-by: Adrian Bunk <[email protected]>

---

;-)

da7d9b1a1d74ba5265d02e316a215540fe2daf19 diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index 7ba1aca..e2c7edd 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -1689,7 +1689,7 @@ static ssize_t hotkey_wakeup_reason_show(struct device *dev,
static struct device_attribute dev_attr_hotkey_wakeup_reason =
__ATTR(wakeup_reason, S_IRUGO, hotkey_wakeup_reason_show, NULL);

-void hotkey_wakeup_reason_notify_change(void)
+static void hotkey_wakeup_reason_notify_change(void)
{
if (tp_features.hotkey_mask)
sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
@@ -1708,7 +1708,7 @@ static struct device_attribute dev_attr_hotkey_wakeup_hotunplug_complete =
__ATTR(wakeup_hotunplug_complete, S_IRUGO,
hotkey_wakeup_hotunplug_complete_show, NULL);

-void hotkey_wakeup_hotunplug_complete_notify_change(void)
+static void hotkey_wakeup_hotunplug_complete_notify_change(void)
{
if (tp_features.hotkey_mask)
sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,

2008-02-13 23:03:51

by Henrique de Moraes Holschuh

Subject: Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static

On Wed, 13 Feb 2008, Adrian Bunk wrote:
> this_patch_makes_the_needlessly_global_hotkey_wakeup_reason_notify_change_and_hotkey_wakeup_hotunplug_complete_notify_change_static
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> ;-)
>
> da7d9b1a1d74ba5265d02e316a215540fe2daf19 diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
> index 7ba1aca..e2c7edd 100644
> --- a/drivers/misc/thinkpad_acpi.c
> +++ b/drivers/misc/thinkpad_acpi.c
> @@ -1689,7 +1689,7 @@ static ssize_t hotkey_wakeup_reason_show(struct device *dev,
> static struct device_attribute dev_attr_hotkey_wakeup_reason =
> __ATTR(wakeup_reason, S_IRUGO, hotkey_wakeup_reason_show, NULL);
>
> -void hotkey_wakeup_reason_notify_change(void)
> +static void hotkey_wakeup_reason_notify_change(void)
> {
> if (tp_features.hotkey_mask)
> sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
> @@ -1708,7 +1708,7 @@ static struct device_attribute dev_attr_hotkey_wakeup_hotunplug_complete =
> __ATTR(wakeup_hotunplug_complete, S_IRUGO,
> hotkey_wakeup_hotunplug_complete_show, NULL);
>
> -void hotkey_wakeup_hotunplug_complete_notify_change(void)
> +static void hotkey_wakeup_hotunplug_complete_notify_change(void)
> {
> if (tp_features.hotkey_mask)
> sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
>

Acked-by: Henrique de Moraes Holschuh <[email protected]>

---

That said, I have no idea what toshiba-acpi has to do with the above patch
;-)

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh

2008-02-14 00:58:37

by Adrian Bunk

Subject: Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static

On Wed, Feb 13, 2008 at 09:03:21PM -0200, Henrique de Moraes Holschuh wrote:
>...
> That said, I have no idea what toshiba-acpi has to do with the above patch
> ;-)

They both begin with a t and end with acpi so they have to be the same,
don't they? ;-)

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed