2008-02-13 21:42:59

by Adrian Bunk

Subject: [2.6 patch] kernel/cpuset.c: make 3 functions static

This patch makes the following needlessly global functions static:
- cpuset_test_cpumask()
- cpuset_change_cpumask()
- cpuset_do_move_task()

Signed-off-by: Adrian Bunk <[email protected]>

---

kernel/cpuset.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

581c9289db3ce36232a9102505f476681c7ecf4c diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 3e296ed..5c21ae9 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -710,7 +710,8 @@ static inline int started_after(void *p1, void *p2)
* Return nonzero if this tasks's cpus_allowed mask should be changed (in other
* words, if its mask is not equal to its cpuset's mask).
*/
-int cpuset_test_cpumask(struct task_struct *tsk, struct cgroup_scanner *scan)
+static int cpuset_test_cpumask(struct task_struct *tsk,
+ struct cgroup_scanner *scan)
{
return !cpus_equal(tsk->cpus_allowed,
(cgroup_cs(scan->cg))->cpus_allowed);
@@ -727,7 +728,8 @@ int cpuset_test_cpumask(struct task_struct *tsk, struct cgroup_scanner *scan)
* We don't need to re-check for the cgroup/cpuset membership, since we're
* holding cgroup_lock() at this point.
*/
-void cpuset_change_cpumask(struct task_struct *tsk, struct cgroup_scanner *scan)
+static void cpuset_change_cpumask(struct task_struct *tsk,
+ struct cgroup_scanner *scan)
{
set_cpus_allowed(tsk, (cgroup_cs(scan->cg))->cpus_allowed);
}
@@ -1648,7 +1650,8 @@ int __init cpuset_init(void)
* Called by cgroup_scan_tasks() for each task in a cgroup.
* Return nonzero to stop the walk through the tasks.
*/
-void cpuset_do_move_task(struct task_struct *tsk, struct cgroup_scanner *scan)
+static void cpuset_do_move_task(struct task_struct *tsk,
+ struct cgroup_scanner *scan)
{
struct cpuset_hotplug_scanner *chsp;

2008-02-14 12:51:59

by Paul Jackson

Subject: Re: [2.6 patch] kernel/cpuset.c: make 3 functions static

Adrian wrote:
> This patch makes the following needlessly global functions static:
> - cpuset_test_cpumask()
> - cpuset_change_cpumask()
> - cpuset_do_move_task()

Thanks.

Signed-off-by: Paul Jackson <[email protected]>

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.940.382.4214