2008-02-15 00:57:21

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN

The pattern for making a config option on purpose not available is a
dependency on BROKEN.

Signed-off-by: Adrian Bunk <[email protected]>

---
79b6f4490cadd62b3601f653df8a27ec2295adf0 diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a370fe8..9fad6da 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -81,7 +81,7 @@ config HEADERS_CHECK

config DEBUG_SECTION_MISMATCH
bool "Enable full Section mismatch analysis"
- depends on UNDEFINED
+ depends on BROKEN
help
The section mismatch analysis checks if there are illegal
references from one section to another section.


2008-02-15 07:33:25

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN

On Fri, Feb 15, 2008 at 02:56:48AM +0200, Adrian Bunk wrote:
> The pattern for making a config option on purpose not available is a
> dependency on BROKEN.
BROKEN says that what is selected by the cofig option
is broken.
This is not the case for DEBUG_SECTION_MISMATCH which is
why it was made dependent on something else.

Sam

2008-02-15 07:41:05

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN

On Fri, Feb 15, 2008 at 08:33:06AM +0100, Sam Ravnborg wrote:
> On Fri, Feb 15, 2008 at 02:56:48AM +0200, Adrian Bunk wrote:
> > The pattern for making a config option on purpose not available is a
> > dependency on BROKEN.
> BROKEN says that what is selected by the cofig option
> is broken.
> This is not the case for DEBUG_SECTION_MISMATCH which is
> why it was made dependent on something else.

BROKEN is our pattern for "intentionally disabled".

I did really grep for UNDEFINED when I first saw it since it might as
well have been some kind of CONFIG_UNDEFINED "warn about undefined foobar".

> Sam

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed