2008-02-15 14:12:01

by Cong Wang

Subject: [Patch] arch/um/kernel/um_arch.c: some small improvements

Make some small improvements for arch/um/kernel/um_arch.c.

Signed-off-by: WANG Cong <[email protected]>
Cc: Jeff Dike <[email protected]>

---
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index a6c1dd1..56deed6 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -115,7 +115,7 @@ static int have_root __initdata = 0;
/* Set in uml_mem_setup and modified in linux_main */
long long physmem_size = 32 * 1024 * 1024;

-static char *usage_string =
+static const char *usage_string =
"User Mode Linux v%s\n"
" available at http://user-mode-linux.sourceforge.net/\n\n";

@@ -202,7 +202,7 @@ static void __init uml_checksetup(char *line, int *add)

p = &__uml_setup_start;
while (p < &__uml_setup_end) {
- int n;
+ size_t n;

n = strlen(p->str);
if (!strncmp(line, p->str, n) && p->setup_func(line + n, add))
@@ -258,7 +258,8 @@ int __init linux_main(int argc, char **argv)
{
unsigned long avail, diff;
unsigned long virtmem_size, max_physmem;
- unsigned int i, add;
+ unsigned int i;
+ int add;
char * mode;

for (i = 1; i < argc; i++) {

2008-02-15 16:03:19

by Jeff Dike

Subject: Re: [uml-devel] [Patch] arch/um/kernel/um_arch.c: some small improvements

On Fri, Feb 15, 2008 at 10:07:42PM +0800, WANG Cong wrote:
>
> Make some small improvements for arch/um/kernel/um_arch.c.
>
> Signed-off-by: WANG Cong <[email protected]>
> Cc: Jeff Dike <[email protected]>

ACK

Jeff

--
Work email - jdike at linux dot intel dot com