I've taken into consideration the various feedback, and
ported the bug fix and other LMB patches posted recently
in an effort to keep the patch churn by others down wrt.
my moving of these files.
1) Use HAVE_LMB as suggested by Sam.
2) Fix potential build errors wrt. asm/prom.h dependencies.
My algorithm was:
a) If the file only included asm/lmb.h I added an include
of both linux/lmb.c and asm/prom.h
b) If the file already includes asm/prom.h, I merely
changed the asm/lmb.h to linux/lmb.h
Header include mimimizations can be done as followon patches.
3) Integrate Kumar Gala's initial region fix.
4) Integrate Becky Bruce's large physical addressing change,
but using u64 instead of phys_addr_t.
It's all at:
master.kernel.org:/pub/scm/linux/kernel/git/davem/lmb-2.6.git
like before.
On Feb 13, 2008, at 7:09 PM, David Miller wrote:
>
> I've taken into consideration the various feedback, and
> ported the bug fix and other LMB patches posted recently
> in an effort to keep the patch churn by others down wrt.
> my moving of these files.
>
> 1) Use HAVE_LMB as suggested by Sam.
>
> 2) Fix potential build errors wrt. asm/prom.h dependencies.
>
> My algorithm was:
>
> a) If the file only included asm/lmb.h I added an include
> of both linux/lmb.c and asm/prom.h
>
> b) If the file already includes asm/prom.h, I merely
> changed the asm/lmb.h to linux/lmb.h
>
> Header include mimimizations can be done as followon patches.
>
> 3) Integrate Kumar Gala's initial region fix.
>
> 4) Integrate Becky Bruce's large physical addressing change,
> but using u64 instead of phys_addr_t.
>
> It's all at:
>
> master.kernel.org:/pub/scm/linux/kernel/git/davem/lmb-2.6.git
>
> like before.
Thanks for picking up the patches from Kumar and myself and fitting
them into your series - this is much appreciated. FYI, I applied the
entire patch series to my local tree and test-booted both mpc8641 and
mpc8568mds and both build and boot cleanly. I also built pasemi and
ebony, those build cleanly as well.
Cheers,
Becky
On Thu, 14 Feb 2008 14:58:22 -0600
Becky Bruce <[email protected]> wrote:
>
> On Feb 13, 2008, at 7:09 PM, David Miller wrote:
>
> >
> > I've taken into consideration the various feedback, and
> > ported the bug fix and other LMB patches posted recently
> > in an effort to keep the patch churn by others down wrt.
> > my moving of these files.
> >
> > 1) Use HAVE_LMB as suggested by Sam.
> >
> > 2) Fix potential build errors wrt. asm/prom.h dependencies.
> >
> > My algorithm was:
> >
> > a) If the file only included asm/lmb.h I added an include
> > of both linux/lmb.c and asm/prom.h
> >
> > b) If the file already includes asm/prom.h, I merely
> > changed the asm/lmb.h to linux/lmb.h
> >
> > Header include mimimizations can be done as followon patches.
> >
> > 3) Integrate Kumar Gala's initial region fix.
> >
> > 4) Integrate Becky Bruce's large physical addressing change,
> > but using u64 instead of phys_addr_t.
> >
> > It's all at:
> >
> > master.kernel.org:/pub/scm/linux/kernel/git/davem/lmb-2.6.git
> >
> > like before.
>
>
> Thanks for picking up the patches from Kumar and myself and fitting
> them into your series - this is much appreciated. FYI, I applied the
> entire patch series to my local tree and test-booted both mpc8641 and
> mpc8568mds and both build and boot cleanly. I also built pasemi and
> ebony, those build cleanly as well.
I plan on actually testing this on Ebony, Walnut, and Bamboo either
later tonight or tomorrow. I don't expect many issues.
Dave, those above boards would cover the build of PowerPC 4xx CPU cores.
Just an FYI.
josh
From: Becky Bruce <[email protected]>
Date: Thu, 14 Feb 2008 14:58:22 -0600
> Thanks for picking up the patches from Kumar and myself and fitting
> them into your series - this is much appreciated. FYI, I applied the
> entire patch series to my local tree and test-booted both mpc8641 and
> mpc8568mds and both build and boot cleanly. I also built pasemi and
> ebony, those build cleanly as well.
Thanks for all of the testing.
From: Josh Boyer <[email protected]>
Date: Thu, 14 Feb 2008 15:24:48 -0600
> I plan on actually testing this on Ebony, Walnut, and Bamboo either
> later tonight or tomorrow. I don't expect many issues.
>
> Dave, those above boards would cover the build of PowerPC 4xx CPU cores.
Ok.
On Thu, Feb 14, 2008 at 02:58:22PM -0600, Becky Bruce wrote:
> Thanks for picking up the patches from Kumar and myself and fitting
> them into your series - this is much appreciated. FYI, I applied the
> entire patch series to my local tree and test-booted both mpc8641 and
> mpc8568mds and both build and boot cleanly. I also built pasemi and
> ebony, those build cleanly as well.
pasemi_defconfig boots happily on my boards here. I've kicked off my
"build all powerpc defconfigs" script while I leave the house for a
couple of hours, but as others have said, no problems are expected...
-Olof
On Thu, 14 Feb 2008 17:21:52 -0600 Olof Johansson <[email protected]> wrote:
>
> On Thu, Feb 14, 2008 at 02:58:22PM -0600, Becky Bruce wrote:
>
> > Thanks for picking up the patches from Kumar and myself and fitting
> > them into your series - this is much appreciated. FYI, I applied the
> > entire patch series to my local tree and test-booted both mpc8641 and
> > mpc8568mds and both build and boot cleanly. I also built pasemi and
> > ebony, those build cleanly as well.
>
> pasemi_defconfig boots happily on my boards here. I've kicked off my
> "build all powerpc defconfigs" script while I leave the house for a
> couple of hours, but as others have said, no problems are expected...
It builds and boots on legacy iSeries (and seems to be working ok) as well.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Wed, 2008-02-13 at 17:09 -0800, David Miller wrote:
> I've taken into consideration the various feedback, and
> ported the bug fix and other LMB patches posted recently
> in an effort to keep the patch churn by others down wrt.
> my moving of these files.
>
> 1) Use HAVE_LMB as suggested by Sam.
>
> 2) Fix potential build errors wrt. asm/prom.h dependencies.
>
> My algorithm was:
>
> a) If the file only included asm/lmb.h I added an include
> of both linux/lmb.c and asm/prom.h
>
> b) If the file already includes asm/prom.h, I merely
> changed the asm/lmb.h to linux/lmb.h
That fixes the build failures I was seeing, ack.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
On Thu, 14 Feb 2008 14:15:31 -0800 (PST)
David Miller <[email protected]> wrote:
> From: Josh Boyer <[email protected]>
> Date: Thu, 14 Feb 2008 15:24:48 -0600
>
> > I plan on actually testing this on Ebony, Walnut, and Bamboo either
> > later tonight or tomorrow. I don't expect many issues.
> >
> > Dave, those above boards would cover the build of PowerPC 4xx CPU cores.
>
> Ok.
Ok, booted just fine on Ebony (PowerPC 440), Bamboo(PowerPC 440 + FPU),
and Haleakala (PowerPC 405).
josh
From: Michael Ellerman <[email protected]>
Date: Sat, 16 Feb 2008 06:05:37 +1100
> That fixes the build failures I was seeing, ack.
Thanks for testing.