2008-02-15 22:29:28

by Chris Snook

Subject: [PATCH] MARKERS depends on MODULES

From: Chris Snook <[email protected]>

Make MARKERS depend on MODULES to prevent build failures with certain configs.

Signed-off-by: Chris Snook <[email protected]>

diff --git a/init/Kconfig b/init/Kconfig
index dcef8b5..933df15 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -729,6 +729,7 @@ config PROFILING

config MARKERS
bool "Activate markers"
+ depends on MODULES
help
Place an empty function call at each marker site. Can be
dynamically changed for a probe function.

2008-02-15 22:37:45

by Mathieu Desnoyers

Subject: Re: [PATCH] MARKERS depends on MODULES

* Chris Snook ([email protected]) wrote:
> From: Chris Snook <[email protected]>
>
> Make MARKERS depend on MODULES to prevent build failures with certain configs.
>
> Signed-off-by: Chris Snook <[email protected]>
>
> diff --git a/init/Kconfig b/init/Kconfig
> index dcef8b5..933df15 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -729,6 +729,7 @@ config PROFILING
>
> config MARKERS
> bool "Activate markers"
> + depends on MODULES
> help
> Place an empty function call at each marker site. Can be
> dynamically changed for a probe function.

It should not be needed. Please try Adrian's fix there :
http://lkml.org/lkml/2008/2/13/714

It should fix your problem.

Mathieu

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68