2008-02-17 08:25:29

by Adrian Bunk

Subject: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>

Every file should include the headers containing the externs its global
code (in this case for struct proc_kmsg_operations).

Signed-off-by: Adrian Bunk <[email protected]>

---
b6f818ea9e2dd76d3fd7dbec2382240cabe66a6b diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index ff3b90b..9fa3a3d 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/poll.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>

#include <asm/uaccess.h>
#include <asm/io.h>

2008-02-17 10:04:04

by Alexey Dobriyan

Subject: Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>

On Sun, Feb 17, 2008 at 10:20:48AM +0200, Adrian Bunk wrote:
> Every file should include the headers containing the externs its global
> code (in this case for struct proc_kmsg_operations).

It should be moved to fs/proc/internal.h to where it belongs.

> --- a/fs/proc/kmsg.c
> +++ b/fs/proc/kmsg.c
> @@ -11,6 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/poll.h>
> #include <linux/fs.h>
> +#include <linux/proc_fs.h>