2008-02-14 00:55:21

by Harvey Harrison

Subject: [PATCH] dlm: match signedness between dlm_config_info and cluster_set

cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
access functions. Make the signedness match to avoid sparse warnings every time
CLUSTER_ATTR is used (lines 149-159) all of the form:

fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
fs/dlm/config.c:149:1: expected unsigned int *info_field
fs/dlm/config.c:149:1: got int extern [toplevel] *<noident>

Signed-off-by: Harvey Harrison <[email protected]>
---
fs/dlm/config.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/dlm/config.c b/fs/dlm/config.c
index c3ad1df..7ceaea3 100644
--- a/fs/dlm/config.c
+++ b/fs/dlm/config.c
@@ -114,7 +114,7 @@ struct cluster_attribute {
};

static ssize_t cluster_set(struct cluster *cl, unsigned int *cl_field,
- unsigned int *info_field, int check_zero,
+ int *info_field, int check_zero,
const char *buf, size_t len)
{
unsigned int x;
--
1.5.4.1.1278.gc75be

2008-02-19 19:47:48

by David Teigland

Subject: Re: [PATCH] dlm: match signedness between dlm_config_info and cluster_set

On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote:
> cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
> access functions. Make the signedness match to avoid sparse warnings every time
> CLUSTER_ATTR is used (lines 149-159) all of the form:
>
> fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
> fs/dlm/config.c:149:1: expected unsigned int *info_field
> fs/dlm/config.c:149:1: got int extern [toplevel] *<noident>
>
> Signed-off-by: Harvey Harrison <[email protected]>

Thanks, added to dlm.git.
Dave