2008-02-19 23:00:44

by Adrian Bunk

Subject: [2.6 patch] sony-laptop.c: fix off-by-one

This patch fixes an off-by-one spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6/drivers/misc/sony-laptop.c.old 2008-02-20 00:26:21.000000000 +0200
+++ linux-2.6/drivers/misc/sony-laptop.c 2008-02-20 00:26:38.000000000 +0200
@@ -314,9 +314,9 @@ static void sony_laptop_report_input_eve
kp.dev = jog_dev;
break;

default:
- if (event > ARRAY_SIZE(sony_laptop_input_index)) {
+ if (event >= ARRAY_SIZE(sony_laptop_input_index)) {
dprintk("sony_laptop_report_input_event, event not known: %d\n", event);
break;
}
if (sony_laptop_input_index[event] != -1) {

2008-02-20 00:19:22

by Mattia Dongili

Subject: Re: [2.6 patch] sony-laptop.c: fix off-by-one

On Wed, Feb 20, 2008 at 12:59:03AM +0200, Adrian Bunk wrote:
> This patch fixes an off-by-one spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Mattia Dongili <[email protected]>

> ---
> --- linux-2.6/drivers/misc/sony-laptop.c.old 2008-02-20 00:26:21.000000000 +0200
> +++ linux-2.6/drivers/misc/sony-laptop.c 2008-02-20 00:26:38.000000000 +0200
> @@ -314,9 +314,9 @@ static void sony_laptop_report_input_eve
> kp.dev = jog_dev;
> break;
>
> default:
> - if (event > ARRAY_SIZE(sony_laptop_input_index)) {
> + if (event >= ARRAY_SIZE(sony_laptop_input_index)) {
> dprintk("sony_laptop_report_input_event, event not known: %d\n", event);
> break;
> }
> if (sony_laptop_input_index[event] != -1) {
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
mattia
:wq!

2008-02-21 12:18:18

by Len Brown

Subject: Re: [2.6 patch] sony-laptop.c: fix off-by-one

On Tuesday 19 February 2008 18:27, Mattia Dongili wrote:
> Acked-by: Mattia Dongili <[email protected]>

applied.

thanks,
-len