2008-02-20 15:00:44

by Stephane Chazelas

Subject: [PATCH 2.6.25-rc2] block2mtd: logging typo fixes

Hi joern,

this patch addresses a number of small issues mainly regarding
the output made by this driver to dmesg:
- Some of the blkmtd's had not been changed to block2mtd which
caused display problem
- the parse_err() macro was displaying "block2mtd: " twice

Signed-off-by: Stephane Chazelas <[email protected]>

--- drivers/mtd/devices/block2mtd.c~ 2008-02-20 14:56:56.942145223 +0000
+++ drivers/mtd/devices/block2mtd.c 2008-02-20 14:57:15.802131021 +0000
@@ -305,7 +305,7 @@ static struct block2mtd_dev *add_device(
}
list_add(&dev->list, &blkmtd_device_list);
INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
- dev->mtd.name + strlen("blkmtd: "),
+ dev->mtd.name + strlen("block2mtd: "),
dev->mtd.erasesize >> 10, dev->mtd.erasesize);
return dev;

@@ -366,9 +366,9 @@ static inline void kill_final_newline(ch
}


-#define parse_err(fmt, args...) do { \
- ERROR("block2mtd: " fmt "\n", ## args); \
- return 0; \
+#define parse_err(fmt, args...) do { \
+ ERROR(fmt, ## args); \
+ return 0; \
} while (0)

#ifndef MODULE
@@ -474,7 +474,7 @@ static void __devexit block2mtd_exit(voi
block2mtd_sync(&dev->mtd);
del_mtd_device(&dev->mtd);
INFO("mtd%d: [%s] removed", dev->mtd.index,
- dev->mtd.name + strlen("blkmtd: "));
+ dev->mtd.name + strlen("block2mtd: "));
list_del(&dev->list);
block2mtd_free_device(dev);
}

2008-02-20 15:35:53

by Jörn Engel

Subject: Re: [PATCH 2.6.25-rc2] block2mtd: logging typo fixes

On Wed, 20 February 2008 15:00:21 +0000, Stephane Chazelas wrote:
>
> this patch addresses a number of small issues mainly regarding
> the output made by this driver to dmesg:
> - Some of the blkmtd's had not been changed to block2mtd which
> caused display problem
> - the parse_err() macro was displaying "block2mtd: " twice
>
> Signed-off-by: Stephane Chazelas <[email protected]>
Acked-by: Joern Engel <[email protected]>

David, please apply.

Jörn

--
"Error protection by error detection and correction."
-- from a university class