2008-02-20 20:58:44

by Jiri Olsa

Subject: [PATCH] fs: removing unused fops from struct char_device_struct

Hi,

seems struct char_device_struct::fops is no longer used, removing it.
I checked with "make allyesconfig" and got proper compile.

Signed-off-by: Jiri Olsa <[email protected]>
---
fs/char_dev.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/char_dev.c b/fs/char_dev.c
index c3bfa76..e4527fb 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -55,7 +55,6 @@ static struct char_device_struct {
unsigned int baseminor;
int minorct;
char name[64];
- struct file_operations *fops;
struct cdev *cdev; /* will die */
} *chrdevs[CHRDEV_MAJOR_HASH_SIZE];

2008-02-21 00:19:14

by Greg KH

Subject: Re: [PATCH] fs: removing unused fops from struct char_device_struct

On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
> Hi,
>
> seems struct char_device_struct::fops is no longer used, removing it.
> I checked with "make allyesconfig" and got proper compile.
>
> Signed-off-by: Jiri Olsa <[email protected]>

Hm, why send this to me?

Did I make the mistake of touching this file last? Hm, nope, someone
else touched it after I did, I'm safe :)

Seriously, I have no problem with this, but it should probably go
through Andrew.

thanks,

greg k-h

2008-02-21 06:09:15

by Jiri Olsa

Subject: Re: [PATCH] fs: removing unused fops from struct char_device_struct

oops, sorry... for some reason I though you were the guy :)
I'll resend

jirka


Greg KH wrote:
> On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
>> Hi,
>>
>> seems struct char_device_struct::fops is no longer used, removing it.
>> I checked with "make allyesconfig" and got proper compile.
>>
>> Signed-off-by: Jiri Olsa <[email protected]>
>
> Hm, why send this to me?
>
> Did I make the mistake of touching this file last? Hm, nope, someone
> else touched it after I did, I'm safe :)
>
> Seriously, I have no problem with this, but it should probably go
> through Andrew.
>
> thanks,
>
> greg k-h
>