2008-02-21 13:18:07

by Glenn Streiff

[permalink] [raw]
Subject: [PATCH 2.6 3/8] infiniband/hw/nes/nes_cm.c: fix a memory leak

From: Adrian Bunk <[email protected]>

This patch fixes a memory leak spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>
Signed-off-by: Glenn Streiff <[email protected]>

---
drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index bd5cfea..78e845c 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -370,11 +370,11 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
int ret = 0;
u32 was_timer_set;

+ if (!cm_node)
+ return -EINVAL;
new_send = kzalloc(sizeof(*new_send), GFP_ATOMIC);
if (!new_send)
return -1;
- if (!cm_node)
- return -EINVAL;

/* new_send->timetosend = currenttime */
new_send->retrycount = NES_DEFAULT_RETRYS;