2008-02-22 20:02:15

by Adrian Bunk

Subject: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>

Every file should include the headers containing the externs its global
functions (in this case for ns_cgroup_clone()).

Signed-off-by: Adrian Bunk <[email protected]>

---
d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
index aead4d6..659f321 100644
--- a/kernel/ns_cgroup.c
+++ b/kernel/ns_cgroup.c
@@ -7,6 +7,7 @@
#include <linux/module.h>
#include <linux/cgroup.h>
#include <linux/fs.h>
+#include <linux/nsproxy.h>

struct ns_cgroup {
struct cgroup_subsys_state css;

2008-02-23 00:02:20

by Serge E. Hallyn

Subject: Re: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>

Quoting Adrian Bunk ([email protected]):
> Every file should include the headers containing the externs its global
> functions (in this case for ns_cgroup_clone()).
>
> Signed-off-by: Adrian Bunk <[email protected]>

Seems fine... and a good way to ensure that the prototype and
definition match.

Acked-by: Serge Hallyn <[email protected]>

thanks,
-serge

>
> ---
> d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
> index aead4d6..659f321 100644
> --- a/kernel/ns_cgroup.c
> +++ b/kernel/ns_cgroup.c
> @@ -7,6 +7,7 @@
> #include <linux/module.h>
> #include <linux/cgroup.h>
> #include <linux/fs.h>
> +#include <linux/nsproxy.h>
>
> struct ns_cgroup {
> struct cgroup_subsys_state css;