2008-02-27 02:23:54

by Li Zefan

Subject: [PATCH] CONNECTOR: make cn_already_initialized static

It is used in connector.c only, so make it static.

Signed-off-by: Li Zefan <[email protected]>
---
drivers/connector/connector.c | 2 +-
include/linux/connector.h | 2 --
2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index fea2d3e..85e2ba7 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -47,7 +47,7 @@ static LIST_HEAD(notify_list);

static struct cn_dev cdev;

-int cn_already_initialized = 0;
+static int cn_already_initialized;

/*
* msg->seq and msg->ack are used to determine message genealogy.
diff --git a/include/linux/connector.h b/include/linux/connector.h
index da6dd95..96a89d3 100644
--- a/include/linux/connector.h
+++ b/include/linux/connector.h
@@ -170,7 +170,5 @@ int cn_cb_equal(struct cb_id *, struct cb_id *);

void cn_queue_wrapper(struct work_struct *work);

-extern int cn_already_initialized;
-
#endif /* __KERNEL__ */
#endif /* __CONNECTOR_H */
--
1.5.4.rc3

2008-02-27 02:25:19

by David Miller

Subject: Re: [PATCH] CONNECTOR: make cn_already_initialized static

From: Li Zefan <[email protected]>
Date: Wed, 27 Feb 2008 10:22:12 +0800

> It is used in connector.c only, so make it static.
>
> Signed-off-by: Li Zefan <[email protected]>

Applied, thanks.

2008-02-27 10:39:54

by Evgeniy Polyakov

Subject: Re: [PATCH] CONNECTOR: make cn_already_initialized static

Hi.

On Tue, Feb 26, 2008 at 06:25:45PM -0800, David Miller ([email protected]) wrote:
> > It is used in connector.c only, so make it static.
> >
> > Signed-off-by: Li Zefan <[email protected]>
>
> Applied, thanks.

Thanks for resolving this guys.

--
Evgeniy Polyakov