2008-03-04 11:38:24

by Kamalesh Babulal

Subject: [PATCH] 2.6.25-rc3-git5 Build fails on s390x

The 2.6.25-rc3-git5 kernel build fails on s390x with

drivers/s390/char/defkeymap.c:155: error: missing terminating ' character
drivers/s390/char/defkeymap.c:156: error: syntax error before ';' token
make[2]: *** [drivers/s390/char/defkeymap.o] Error 1
make[1]: *** [drivers/s390/char] Error 2
make: *** [drivers/s390] Error 2

I have tested the patch for build failure only.

Signed-off-by: Kamalesh Babulal <[email protected]>
--
diff --git a/drivers/s390/char/defkeymap.c b/drivers/s390/char/defkeymap.c
index 9692d6a..07c7f31 100644
--- a/drivers/s390/char/defkeymap.c
+++ b/drivers/s390/char/defkeymap.c
@@ -152,7 +152,7 @@ char *func_table[MAX_NR_FUNC] = {

struct kbdiacruc accent_table[MAX_DIACR] = {
{'^', 'c', 0003}, {'^', 'd', 0004},
- {'^', 'z', 0032}, {'^', 0012', 0000},
+ {'^', 'z', 0032}, {'^', 0012, 0000},
};

unsigned int accent_table_size = 4;
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

2008-03-04 12:09:53

by Martin Schwidefsky

Subject: Re: [PATCH] 2.6.25-rc3-git5 Build fails on s390x

On Tue, 2008-03-04 at 17:08 +0530, Kamalesh Babulal wrote:
> The 2.6.25-rc3-git5 kernel build fails on s390x with
>
> drivers/s390/char/defkeymap.c:155: error: missing terminating ' character
> drivers/s390/char/defkeymap.c:156: error: syntax error before ';' token
> make[2]: *** [drivers/s390/char/defkeymap.o] Error 1
> make[1]: *** [drivers/s390/char] Error 2
> make: *** [drivers/s390] Error 2
>
> I have tested the patch for build failure only.
>
> Signed-off-by: Kamalesh Babulal <[email protected]>

Added to the queue with a small change to the description.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.