2008-02-27 21:24:45

by Adrian Bunk

Subject: [2.6 patch] crypto/digest.c should #include "internal.h"

Every file should include the headers containing the externs for its
global code (in this case for struct crypto_{init,exit}_digest_ops()).

Signed-off-by: Adrian Bunk <[email protected]>

---
8680cc7b83fdcef7fbb84f9eac3f26f3d3e16b45 foobar
diff --git a/crypto/digest.c b/crypto/digest.c
index 6fd43bd..b526cc3 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -21,6 +21,8 @@
#include <linux/module.h>
#include <linux/scatterlist.h>

+#include "internal.h"
+
static int init(struct hash_desc *desc)
{
struct crypto_tfm *tfm = crypto_hash_tfm(desc->tfm);

2008-03-05 11:06:42

by Herbert Xu

Subject: Re: [2.6 patch] crypto/digest.c should #include "internal.h"

On Wed, Feb 27, 2008 at 11:21:03PM +0200, Adrian Bunk wrote:
> Every file should include the headers containing the externs for its
> global code (in this case for struct crypto_{init,exit}_digest_ops()).
>
> Signed-off-by: Adrian Bunk <[email protected]>

Applied to crypto-2.6. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt