2008-03-07 09:46:04

by Atsushi Nemoto

[permalink] [raw]
Subject: [PATCH] at73c213: Fix error checking for clk API.

The clk_round_rate() and clk_set_rate() will return int, so not store
thier return value to unsigned long variable. This bug hides real
error on these API.

Signed-off-by: Atsushi Nemoto <[email protected]>
---
diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c
index 89d6e9c..d130552 100644
--- a/sound/spi/at73c213.c
+++ b/sound/spi/at73c213.c
@@ -133,7 +133,8 @@ static struct snd_pcm_hardware snd_at73c213_playback_hw = {
static int snd_at73c213_set_bitrate(struct snd_at73c213 *chip)
{
unsigned long ssc_rate = clk_get_rate(chip->ssc->clk);
- unsigned long dac_rate_new, ssc_div, status;
+ unsigned long dac_rate_new, ssc_div;
+ int status;
unsigned long ssc_div_max, ssc_div_min;
int max_tries;