2008-03-18 09:03:22

by Rami Rosen

[permalink] [raw]
Subject: [PATCH] [IPV6] remove unused parameter (struct sock parameter) from ip6_route_output()

Hi,
This patch removes the struct sock parameter from ip6_route_output();
looking at the ip6_route_output() implementation in net/ipv6/route.c
will show immediately that it is not used in this method.

In fact, icmp.c and ip6_output.c are the only places in the kernel
where the sk (struct sock) parameter passed to ip6_route_output() is not NULL;
anyhow, as explained above, this parameter is unused; changing
the ip6_route_output() prototype by omitting the struct sock parameter
does not break anything.


Regards,
Rami Rosen


Signed-off-by: Rami Rosen <[email protected]>


Attachments:
(No filename) (578.00 B)
patch.txt (5.85 kB)
Download all attachments

2008-03-18 09:14:49

by YOSHIFUJI Hideaki

[permalink] [raw]
Subject: Re: [PATCH] [IPV6] remove unused parameter (struct sock parameter) from ip6_route_output()

NAK; I have a plan to use it in net-2.6.26 tree.

--yoshfuji

In article <[email protected]> (at Tue, 18 Mar 2008 11:03:04 +0200), "Rami Rosen" <[email protected]> says:

> Hi,
> This patch removes the struct sock parameter from ip6_route_output();
> looking at the ip6_route_output() implementation in net/ipv6/route.c
> will show immediately that it is not used in this method.
>
> In fact, icmp.c and ip6_output.c are the only places in the kernel
> where the sk (struct sock) parameter passed to ip6_route_output() is not NULL;
> anyhow, as explained above, this parameter is unused; changing
> the ip6_route_output() prototype by omitting the struct sock parameter
> does not break anything.
>
>
> Regards,
> Rami Rosen
>
>
> Signed-off-by: Rami Rosen <[email protected]>