2008-03-21 22:50:16

by Chris Wright

[permalink] [raw]
Subject: [patch 65/76] sched_nr_migrate wrong mode bits

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Michal Schmidt <[email protected]>

sched_nr_migrate has strange permission bits:

$ ls -l /proc/sys/kernel/sched_nr_migrate
--w----r-T 1 root root 0 2008-03-17 23:31 /proc/sys/kernel/sched_nr_migrate

The bug is an obvious decimal/octal confusion.

Fixed (collaterally) in Linus's tree by Peter Zijlstra with commit fa85ae241
"sched: rt time limit" (in 2.6.25-rc1).

Signed-off-by: Michal Schmidt <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
kernel/sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -306,7 +306,7 @@ static struct ctl_table kern_table[] = {
.procname = "sched_nr_migrate",
.data = &sysctl_sched_nr_migrate,
.maxlen = sizeof(unsigned int),
- .mode = 644,
+ .mode = 0644,
.proc_handler = &proc_dointvec,
},
#endif

--