2008-03-25 23:53:58

by Benjamin Herrenschmidt

Subject: [PATCH] pata_sil680: Only enable MMIO on Cell blades

There have been reported regressions of the SIL 680 driver when
using MMIO, so this makes it only try MMIO on Cell blades where
it's known to be necessary (the host bridge doesn't do PIO on these).

We'll try to find the root problem with MMIO separately.

Signed-off-by: Benjamin Herrenschmidt <[email protected]>
---

drivers/ata/pata_sil680.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

--- linux-work.orig/drivers/ata/pata_sil680.c 2008-03-26 10:43:20.000000000 +1100
+++ linux-work/drivers/ata/pata_sil680.c 2008-03-26 10:43:34.000000000 +1100
@@ -269,7 +269,11 @@ static u8 sil680_init_chip(struct pci_de
dev_dbg(&pdev->dev, "sil680: BA5_EN = %d clock = %02X\n",
tmpbyte & 1, tmpbyte & 0x30);

- *try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);
+ *try_mmio = 0;
+#ifdef CONFIG_PPC
+ if (machine_is(cell))
+ *try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);
+#endif

switch(tmpbyte & 0x30) {
case 0x00:

2008-03-26 00:06:49

by Alan

Subject: Re: [PATCH] pata_sil680: Only enable MMIO on Cell blades

On Wed, 26 Mar 2008 10:50:41 +1100
Benjamin Herrenschmidt <[email protected]> wrote:

> There have been reported regressions of the SIL 680 driver when
> using MMIO, so this makes it only try MMIO on Cell blades where
> it's known to be necessary (the host bridge doesn't do PIO on these).
>
> We'll try to find the root problem with MMIO separately.
>
> Signed-off-by: Benjamin Herrenschmidt <[email protected]>

Acked-by: Alan Cox <[email protected]>