2008-03-26 17:17:53

by Bjorn Helgaas

[permalink] [raw]
Subject: [patch 25/37] PNPACPI: remove redundant warnings about _CRS/_PRS failures

Any errors should already be reported inside
pnpacpi_parse_allocated_resource() and
pnpacpi_parse_resource_option_data(), so no
need to report them again.

Signed-off-by: Bjorn Helgaas <[email protected]>

Index: work7/drivers/pnp/pnpacpi/core.c
===================================================================
--- work7.orig/drivers/pnp/pnpacpi/core.c 2008-03-21 15:22:09.000000000 -0600
+++ work7/drivers/pnp/pnpacpi/core.c 2008-03-21 15:22:51.000000000 -0600
@@ -180,22 +180,11 @@
else
strncpy(dev->name, acpi_device_bid(device), sizeof(dev->name));

- if (dev->active) {
- /* parse allocated resource */
- status = pnpacpi_parse_allocated_resource(dev);
- if (ACPI_FAILURE(status) && (status != AE_NOT_FOUND)) {
- pnp_err("PnPACPI: METHOD_NAME__CRS failure for %s",
- acpi_device_hid(device));
- }
- }
+ if (dev->active)
+ pnpacpi_parse_allocated_resource(dev);

- if (dev->capabilities & PNP_CONFIGURABLE) {
- status = pnpacpi_parse_resource_option_data(dev);
- if (ACPI_FAILURE(status) && (status != AE_NOT_FOUND)) {
- pnp_err("PnPACPI: METHOD_NAME__PRS failure for %s",
- acpi_device_hid(device));
- }
- }
+ if (dev->capabilities & PNP_CONFIGURABLE)
+ pnpacpi_parse_resource_option_data(dev);

if (device->flags.compatible_ids) {
struct acpi_compatible_id_list *cid_list = device->pnp.cid_list;

--