2008-03-30 22:17:32

by Denys Vlasenko

[permalink] [raw]
Subject: [PATCH] sge.c: stop inlining largish static functions

Hi Jeff,

Can you take this patch into your net driver fixes tree?

I noticed that drivers/net/cxgb3/sge.c has lots of inlined
static functions.

Some of big inlines are single use, but at least make_sgl()
has two callsites. I didn't check every function after it...

This patch removes "inline" from biggest static function
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).

Size difference for 32bit x86:

text data bss dec hex filename
14036 0 0 14036 36d4 linux-2.6-ALLYES/drivers/net/cxgb3/sge.o
13185 0 0 13185 3381 linux-2.6.inline-ALLYES/drivers/net/cxgb3/sge.o

Signed-off-by: Denys Vlasenko <[email protected]>
--
vda


Attachments:
(No filename) (732.00 B)
sge_deinline.diff (11.92 kB)
Download all attachments