2008-04-01 01:15:27

by Denys Vlasenko

[permalink] [raw]
Subject: [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions

Hi John,

Can you please take a look at this patch?

drivers/atm/ambassador.c has unusually large number
of static inline functions - 22.

I looked through them and half of them seem to be too big
to warrant inlining.

This patch removes "inline" from these static functions
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).

Size difference for 32bit x86:
text data bss dec hex filename
10209 8488 4 18701 490d linux-2.6-ALLYES/drivers/atm/ambassador.o
9462 8488 4 17954 4622 linux-2.6.inline-ALLYES/drivers/atm/ambassador.o

Signed-off-by: Denys Vlasenko <[email protected]>
--
vda


Attachments:
(No filename) (683.00 B)
deinline_ambassador.diff (6.60 kB)
Download all attachments