2008-04-01 02:37:13

by Denys Vlasenko

[permalink] [raw]
Subject: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions

Hi Takashi,

Can you please take a look at this patch?

sound/pci/rme9652/hdspm.c has unusually large number
of static inline functions - 22.

I looked through them and some of them seem to be too big
to warrant inlining.

This patch removes "inline" from these static functions
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).

Size difference on 32bit x86:
text data bss dec hex filename
20437 2160 516 23113 5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o
18036 2160 516 20712 50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o

Signed-off-by: Denys Vlasenko <[email protected]>
--
vda


Attachments:
(No filename) (688.00 B)
deinline_hdspm.diff (4.84 kB)
Download all attachments