2008-06-02 12:30:17

by Russell King

Subject: Re: [PATCH 6/10] arm: convert to generic helpers for IPI function calls

On Thu, May 29, 2008 at 10:58:20AM +0200, Jens Axboe wrote:
> This converts arm to use the new helpers for smp_call_function() and
> friends, and adds support for smp_call_function_single().

> +void arch_send_call_function_ipi(cpumask_t mask)
> {
> - return smp_call_function_on_cpu(func, info, retry, wait,
> - cpu_online_map);
> + send_ipi_message(mask, IPI_CALL_FUNC);
> }

Can things like the above be inline functions to be included in the
generic code?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:

2008-06-06 08:47:28

by Jens Axboe

Subject: Re: [PATCH 6/10] arm: convert to generic helpers for IPI function calls

On Mon, Jun 02 2008, Russell King wrote:
> On Thu, May 29, 2008 at 10:58:20AM +0200, Jens Axboe wrote:
> > This converts arm to use the new helpers for smp_call_function() and
> > friends, and adds support for smp_call_function_single().
>
> > +void arch_send_call_function_ipi(cpumask_t mask)
> > {
> > - return smp_call_function_on_cpu(func, info, retry, wait,
> > - cpu_online_map);
> > + send_ipi_message(mask, IPI_CALL_FUNC);
> > }
>
> Can things like the above be inline functions to be included in the
> generic code?

Sure, it could be put asm/smp.h for the supported archs.

--
Jens Axboe