2008-06-09 18:46:58

by scameron

Subject: [patch] cciss: Fix regression that no device nodes are created if no logical drives are configured.

Fix regression in cciss driver that if no logical drives are configured,
no device nodes at all get created.

Signed-off-by: Stephen M. Cameron <[email protected]>

---

drivers/block/cciss.c | 4 ++++
1 files changed, 4 insertions(+)

diff -puN drivers/block/cciss.c~cciss_fix_cxd0_missing_if_no_drives drivers/block/cciss.c
--- linux-2.6.26rc5/drivers/block/cciss.c~cciss_fix_cxd0_missing_if_no_drives 2008-06-09 09:27:37.000000000 -0500
+++ linux-2.6.26rc5-root/drivers/block/cciss.c 2008-06-09 12:33:07.000000000 -0500
@@ -3535,6 +3535,10 @@ static int __devinit cciss_init_one(stru
for (j = 0; j <= hba[i]->highest_lun; j++)
add_disk(hba[i]->gendisk[j]);

+ /* we must register the controller even if no disks exist */
+ if (hba[i]->highest_lun == -1)
+ add_disk(hba[i]->gendisk[0]);
+
return 1;

clean4:
_

2008-06-09 19:59:31

by Mike Miller (OS Dev)

Subject: Re: [patch] cciss: Fix regression that no device nodes are created if no logical drives are configured.

On Mon, Jun 09, 2008 at 01:46:49PM -0500, [email protected] wrote:
>
>
> Fix regression in cciss driver that if no logical drives are configured,
> no device nodes at all get created.
>
> Signed-off-by: Stephen M. Cameron <[email protected]>
Acked-by: Mike Miller <[email protected]>
>
> ---
>
> drivers/block/cciss.c | 4 ++++
> 1 files changed, 4 insertions(+)
>
> diff -puN drivers/block/cciss.c~cciss_fix_cxd0_missing_if_no_drives drivers/block/cciss.c
> --- linux-2.6.26rc5/drivers/block/cciss.c~cciss_fix_cxd0_missing_if_no_drives 2008-06-09 09:27:37.000000000 -0500
> +++ linux-2.6.26rc5-root/drivers/block/cciss.c 2008-06-09 12:33:07.000000000 -0500
> @@ -3535,6 +3535,10 @@ static int __devinit cciss_init_one(stru
> for (j = 0; j <= hba[i]->highest_lun; j++)
> add_disk(hba[i]->gendisk[j]);
>
> + /* we must register the controller even if no disks exist */
> + if (hba[i]->highest_lun == -1)
> + add_disk(hba[i]->gendisk[0]);
> +
> return 1;
>
> clean4:
> _