2008-06-10 11:58:26

by Haavard Skinnemoen

[permalink] [raw]
Subject: Re: Latest gpio gumph

David Brownell <[email protected]> wrote:
> [ Re that one avr32 patch: ]
>
> On Wednesday 28 May 2008, Haavard Skinnemoen wrote:
> > I'm not really opposed to the second change; I would have applied it if
> > it came separately. But I think the first change is wrong.
>
> OK, then feel free to strip out the first chunk and just take that.

Applied the patch below. Thanks.

Haavard

>From bab0d89419e2d30199420da0af29a8b5662af018 Mon Sep 17 00:00:00 2001
From: David Brownell <[email protected]>
Date: Tue, 10 Jun 2008 13:55:52 +0200
Subject: [PATCH] avr32: minor GPIO handling updates

On the odd chance some code uses a pin as a GPIO IRQ without calling
gpio_request() or gpio_direction_input(), the debug dump should still
show its pin status.

Signed-off-by: David Brownell <[email protected]>
Signed-off-by: Haavard Skinnemoen <[email protected]>
---
arch/avr32/mach-at32ap/pio.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c
index 38a8fa3..60da03b 100644
--- a/arch/avr32/mach-at32ap/pio.c
+++ b/arch/avr32/mach-at32ap/pio.c
@@ -318,6 +318,8 @@ static void pio_bank_show(struct seq_file *s, struct gpio_chip *chip)
const char *label;

label = gpiochip_is_requested(chip, i);
+ if (!label && (imr & mask))
+ label = "[irq]";
if (!label)
continue;

--
1.5.5.3